Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elixir #190

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@bradcypert
Copy link

commented May 3, 2019

This PR adds in support for Elixir into SpaceFish. This matches parity of the feature in https://github.com/denysdovhan/spaceship-prompt

Description

Adds in a section for Elixir support into SpaceFish. It checks against iex, exenv and elixir to see if you have an elixir install and only shows in directories that contain mix.ex or other elixir files. It's configureable via the following options:

Variable Default Meaning
SPACESHIP_ELIXIR_SHOW true Show current Elixir version
SPACEFISH_ELIXIR_PREFIX $SPACEFISH_PROMPT_DEFAULT_PREFIX Prefix before the elixir section
SPACEFISH_ELIXIR_SUFFIX $SPACEFISH_PROMPT_DEFAULT_SUFFIX Suffix after the elixir section
SPACEFISH_ELIXIR_SYMBOL 馃挧路 Character to be shown before Elixir version
SPACEFISH_ELIXIR_COLOR magenta Color of Elixir section

Motivation and Context

This helps maintain the mission of absolute parity with Spaceship.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

This was tested by writing and running unit tests for my code. I wasn't able to find the build instructions, so I'm unsure how to actually build and test this locally, however.

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
@matchai
Copy link
Owner

left a comment

Thank you for your contribution @bradcypert! Looks like a solid PR to me. 馃槃

I just wonder what's going on with the Linux builds on Travis...
The tests look like they should pass, but for whatever reason, it seems we're getting the wrong version in CI.
Is the mock not working? Does Travis already have Elixir installed? 馃

Show resolved Hide resolved functions/__sf_section_elixir.fish Outdated
Show resolved Hide resolved functions/__sf_section_elixir.fish Outdated

matchai and others added some commits May 4, 2019

Update functions/__sf_section_elixir.fish
Co-Authored-By: bradcypert <brad.cypert@gmail.com>
Update functions/__sf_section_elixir.fish
Co-Authored-By: bradcypert <brad.cypert@gmail.com>
@bradcypert

This comment has been minimized.

Copy link
Author

commented May 4, 2019

@matchai thanks for looking over my PR and showing me a more idiomatic way to handle the search of a string. I'm not 100% sure why tests would be getting a different version on Linux. As far as I know, the Linux image shouldn't have elixir preinstalled on it and it doesn't look like the travis.yml is adding any elixir stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.