New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Drop embedded MathJax in favor of using distro-packaged one? #158

Closed
monsta opened this Issue Sep 7, 2015 · 9 comments

Comments

Projects
None yet
7 participants
@monsta
Member

monsta commented Sep 7, 2015

Well, it has been done in Debian here - as a patch. Can we do the same upstream and drop the excessive amount of source code?

@infirit @flexiondotorg @NiceandGently @willysr @posophe @obache
thoughts?

yes, some of you have already confirmed that MathJax is in your distros, I know 😄

@infirit

This comment has been minimized.

Show comment
Hide comment
@infirit

infirit Sep 7, 2015

Contributor

I am not against removing and relying on the distro's packaged version. I am only concerned about distro's that do not have this packaged, slackware was one but then I don't think @willysr enabled epub in atril..

Contributor

infirit commented Sep 7, 2015

I am not against removing and relying on the distro's packaged version. I am only concerned about distro's that do not have this packaged, slackware was one but then I don't think @willysr enabled epub in atril..

@infirit infirit added the confirmed label Sep 7, 2015

@infirit infirit changed the title from Drop embedded MathJax in favor of using distro-packaged one? to RFC: Drop embedded MathJax in favor of using distro-packaged one? Sep 7, 2015

@flexiondotorg

This comment has been minimized.

Show comment
Hide comment
@flexiondotorg

flexiondotorg Sep 7, 2015

Member

I agree with this proposal.

Member

flexiondotorg commented Sep 7, 2015

I agree with this proposal.

@willysr

This comment has been minimized.

Show comment
Hide comment
@willysr

willysr Sep 7, 2015

Member

yes, go on with this idea :)
just let me know when it has become a mandatory dep

Member

willysr commented Sep 7, 2015

yes, go on with this idea :)
just let me know when it has become a mandatory dep

@obache

This comment has been minimized.

Show comment
Hide comment
@obache

obache Sep 8, 2015

I agree with this idea too.

I don't know whether "/usr/share/javascript/mathjax" is the de facto standard location for MathJax installation or not, but it is better to add a configure option to specify the location (with existence and required version check). I will also avoid potential missing dependency from packaging.

obache commented Sep 8, 2015

I agree with this idea too.

I don't know whether "/usr/share/javascript/mathjax" is the de facto standard location for MathJax installation or not, but it is better to add a configure option to specify the location (with existence and required version check). I will also avoid potential missing dependency from packaging.

@posophe

This comment has been minimized.

Show comment
Hide comment
@posophe

posophe Sep 8, 2015

I agree too. And don't worry, I'll package it by basing it on Fedora's

posophe commented Sep 8, 2015

I agree too. And don't worry, I'll package it by basing it on Fedora's

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta Sep 10, 2015

Member

Ok, there goes #160.

Member

monsta commented Sep 10, 2015

Ok, there goes #160.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Oct 14, 2015

Member

@monsta
Do i have to include MathJax as runtime require in downstream package?

Member

raveit65 commented Oct 14, 2015

@monsta
Do i have to include MathJax as runtime require in downstream package?

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Oct 14, 2015

Member

ok. i see it is already in debian control

Member

raveit65 commented Oct 14, 2015

ok. i see it is already in debian control

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta Oct 14, 2015

Member

Yes, runtime dep has to be there - in debian it's libjs-mathjax.

Member

monsta commented Oct 14, 2015

Yes, runtime dep has to be there - in debian it's libjs-mathjax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment