Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writes filenames of opened files to system logs #315

Closed
Safari77 opened this issue Apr 20, 2018 · 3 comments · Fixed by #338
Closed

Writes filenames of opened files to system logs #315

Safari77 opened this issue Apr 20, 2018 · 3 comments · Fixed by #338
Labels
confirmed

Comments

@Safari77
Copy link

Expected behaviour

There's enough spam already, writing six lines of logs for each opened file is not strictly necessary, at least when I have not enabled any debugging options.

Actual behaviour

dbus-daemon[7605]: [session uid=500 pid=7605] Activating service name='org.mate.atril.Daemon' requested by ':1.2562' (uid=500 pid=1045497 comm="atril filename.pdf ")
dbus-daemon[7605]: [session uid=500 pid=7605] Successfully activated service 'org.mate.atril.Daemon'
org.mate.atril.Daemon[7605]: RegisterDocument registered owner ':1.2562' for URI 'file:///filename.pdf'
org.mate.atril.Daemon[7605]: Watch name':1.2562' appeared with owner ':1.2562'
org.mate.atril.Daemon[7605]: RegisterDocument process pending invocations for URI file:///filename.pdf
org.mate.atril.Daemon[7605]: UnregisterDocument URI 'file:///filename.pdf'

Steps to reproduce the behaviour

atril filename.pdf

MATE general version

1.20.1

Package version

1.20.1

Linux Distribution

Fedora 27

link to downstream report of your Distribution
@lukefromdc
Copy link
Member

This is also a privacy issue and a security hazard to anyone using a non-encrypted / partition. Someone encrypting only /home and thinking they are protected could get quite a surprise when the filename of a document released over official objections by a whistleblower turns up in a system log admitted into evidence against them in a courtroom somewhere.

@rcaridade145
Copy link

@lukefromdc this commit https://gitlab.gnome.org/GNOME/evince/commit/707725e986844d3cc4340f9f2cbb1343165d4b59 seems to fix this issue.

@raveit65
Copy link
Member

The evince commit helps a bit.
journalctl -b0 -f --no-tail with

  • atril from master:
Okt 25 16:03:33 mother.mother.loc dbus-daemon[1697]: [session uid=1000 pid=1697] Activating service name='org.mate.atril.Daemon' requested by ':1.142' (uid=1000 pid=11637 comm="atril Briefmarken.1Stk.20.10.2018_0026.pdf ")
Okt 25 16:03:33 mother.mother.loc dbus-daemon[1697]: [session uid=1000 pid=1697] Successfully activated service 'org.mate.atril.Daemon'
Okt 25 16:03:33 mother.mother.loc org.mate.atril.Daemon[1697]: RegisterDocument registered owner ':1.142' for URI 'file:///media/Doggy/Dokumente/DHL/Briefmarken.1Stk.20.10.2018_0026.pdf'
Okt 25 16:03:33 mother.mother.loc org.mate.atril.Daemon[1697]: Watch name':1.142' appeared with owner ':1.142'
Okt 25 16:03:33 mother.mother.loc org.mate.atril.Daemon[1697]: RegisterDocument process pending invocations for URI file:///media/Doggy/Dokumente/DHL/Briefmarken.1Stk.20.10.2018_0026.pdf
Okt 25 16:03:58 mother.mother.loc org.mate.atril.Daemon[1697]: UnregisterDocument URI 'file:///media/Doggy/Dokumente/DHL/Briefmarken.1Stk.20.10.2018_0026.pdf'
  • master+ evince commit
Okt 25 16:46:27 mother.mother.loc dbus-daemon[1697]: [session uid=1000 pid=1697] Activating service name='org.mate.atril.Daemon' requested by ':1.157' (uid=1000 pid=30205 comm="atril Briefmarken.1Stk.20.10.2018_0026.pdf ")
Okt 25 16:46:27 mother.mother.loc dbus-daemon[1697]: [session uid=1000 pid=1697] Successfully activated service 'org.mate.atril.Daemon'

For some reason dbus-daemon itself is noisy too.

Any way, i will open a PR.

raveit65 pushed a commit that referenced this issue Oct 25, 2018
@gcampax @raveit65
Reduce the chattiness of the evince daemon
a21e6e3 
Use g_debug instead of g_printerr for debug warnings that happen
during normal operation. This way messages are suppressed, unless
the G_MESSAGES_DEBUG variable is set, and we avoid filling everyone's
journal with repetitive debugging info.

https://bugzilla.gnome.org/show_bug.cgi?id=723972

origin commit:
https://gitlab.gnome.org/GNOME/evince/commit/707725e

fixes #315
@raveit65 raveit65 mentioned this issue Oct 25, 2018
Merged
raveit65 pushed a commit that referenced this issue Oct 25, 2018
@gcampax @raveit65
Reduce the chattiness of atril daemon
a6fc396 
Use g_debug instead of g_printerr for debug warnings that happen
during normal operation. This way messages are suppressed, unless
the G_MESSAGES_DEBUG variable is set, and we avoid filling everyone's
journal with repetitive debugging info.

https://bugzilla.gnome.org/show_bug.cgi?id=723972

origin commit:
https://gitlab.gnome.org/GNOME/evince/commit/707725e

fixes #315
raveit65 pushed a commit that referenced this issue Oct 26, 2018
@gcampax @raveit65
Reduce the chattiness of atril daemon
f4b9c80 
Use g_debug instead of g_printerr for debug warnings that happen
during normal operation. This way messages are suppressed, unless
the G_MESSAGES_DEBUG variable is set, and we avoid filling everyone's
journal with repetitive debugging info.

https://bugzilla.gnome.org/show_bug.cgi?id=723972

origin commit:
https://gitlab.gnome.org/GNOME/evince/commit/707725e

fixes #315
Piiit pushed a commit to Piiit/xreader that referenced this issue Jun 28, 2019
@gcampax @Piiit
ATRIL BACKPORTS: Reduce the chattiness of atril daemon
153c4ad 
Backported by Peter Moser <pitiz29a@gmail.com>

Fixes linuxmint#155

Taken from:
mate-desktop/atril@a6fc396acbb6ef2e71f138

commit a6fc396acbb6ef2e71f13879ec2ee43f686f90c1
Author: Giovanni Campagna <gcampagna@src.gnome.org>
Date:   Sun Feb 9 18:37:37 2014 +0100

    Reduce the chattiness of atril daemon

    Use g_debug instead of g_printerr for debug warnings that happen
    during normal operation. This way messages are suppressed, unless
    the G_MESSAGES_DEBUG variable is set, and we avoid filling everyone's
    journal with repetitive debugging info.

    https://bugzilla.gnome.org/show_bug.cgi?id=723972

    origin commit:
    https://gitlab.gnome.org/GNOME/evince/commit/707725e

    fixes mate-desktop/atril#315
clefebvre pushed a commit to linuxmint/xreader that referenced this issue Jun 28, 2019
@Piiit @clefebvre
xreaderd logging (#318)
a92b172 
* ATRIL BACKPORTS: Reduce the chattiness of atril daemon

Backported by Peter Moser <pitiz29a@gmail.com>

Fixes #155

Taken from:
mate-desktop/atril@a6fc396acbb6ef2e71f138

commit a6fc396acbb6ef2e71f13879ec2ee43f686f90c1
Author: Giovanni Campagna <gcampagna@src.gnome.org>
Date:   Sun Feb 9 18:37:37 2014 +0100

    Reduce the chattiness of atril daemon

    Use g_debug instead of g_printerr for debug warnings that happen
    during normal operation. This way messages are suppressed, unless
    the G_MESSAGES_DEBUG variable is set, and we avoid filling everyone's
    journal with repetitive debugging info.

    https://bugzilla.gnome.org/show_bug.cgi?id=723972

    origin commit:
    https://gitlab.gnome.org/GNOME/evince/commit/707725e

    fixes mate-desktop/atril#315

* doc: Explain how to run the daemon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce the chattiness of atril daemon mate-desktop/atril
5 participants
@raveit65 @Safari77 @monsta @rcaridade145 @lukefromdc