Skip to content

Commit 157d047

Browse files
sc0wlukefromdc
authored andcommitted
fm-properties-window: Fix memory leaks
'g_strconcat' needs to be freed
1 parent bd0d998 commit 157d047

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

src/file-manager/fm-properties-window.c

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3039,6 +3039,7 @@ create_pie_widget (FMPropertiesWindow *window)
30393039
gchar *free;
30403040
const char *fs_type;
30413041
gchar *uri;
3042+
gchar *concat;
30423043
GFile *location;
30433044
GFileInfo *info;
30443045

@@ -3093,7 +3094,9 @@ create_pie_widget (FMPropertiesWindow *window)
30933094

30943095
gtk_widget_set_size_request (used_canvas, 20, 20);
30953096
/* Translators: "used" refers to the capacity of the filesystem */
3096-
used_label = gtk_label_new (g_strconcat (used, " ", _("used"), NULL));
3097+
concat = g_strconcat (used, " ", _("used"), NULL);
3098+
used_label = gtk_label_new (concat);
3099+
g_free (concat);
30973100

30983101
free_canvas = gtk_drawing_area_new ();
30993102

@@ -3102,9 +3105,13 @@ create_pie_widget (FMPropertiesWindow *window)
31023105

31033106
gtk_widget_set_size_request (free_canvas, 20, 20);
31043107
/* Translators: "free" refers to the capacity of the filesystem */
3105-
free_label = gtk_label_new (g_strconcat (free, " ", _("free"), NULL));
3108+
concat = g_strconcat (free, " ", _("free"), NULL);
3109+
free_label = gtk_label_new (concat);
3110+
g_free (concat);
31063111

3107-
capacity_label = gtk_label_new (g_strconcat (_("Total capacity:"), " ", capacity, NULL));
3112+
concat = g_strconcat (_("Total capacity:"), " ", capacity, NULL);
3113+
capacity_label = gtk_label_new (concat);
3114+
g_free (concat);
31083115
fstype_label = gtk_label_new (NULL);
31093116

31103117
location = g_file_new_for_uri (uri);
@@ -3113,9 +3120,9 @@ create_pie_widget (FMPropertiesWindow *window)
31133120
if (info) {
31143121
fs_type = g_file_info_get_attribute_string (info, G_FILE_ATTRIBUTE_FILESYSTEM_TYPE);
31153122
if (fs_type != NULL) {
3116-
gchar *fstype_text = g_strconcat (_("Filesystem type:"), " ", fs_type, NULL);
3117-
gtk_label_set_text (GTK_LABEL (fstype_label), fstype_text);
3118-
g_free (fstype_text);
3123+
concat = g_strconcat (_("Filesystem type:"), " ", fs_type, NULL);
3124+
gtk_label_set_text (GTK_LABEL (fstype_label), concat);
3125+
g_free (concat);
31193126
}
31203127

31213128
g_object_unref (info);

0 commit comments

Comments
 (0)