Skip to content


[file-manager] Fix apparent bug in context menu updating code.
Browse files Browse the repository at this point in the history
The code looked like it was supposed to check whether each file in the
selection could be opened in an external app, but was only checking the
first item in the selection repeatedly.

This bug may have been mostly benign since the subsequent call to
caja_mime_get_default_application_for_files will return NULL anyway if the
files don't all match each other.
  • Loading branch information
Max-E authored and lukefromdc committed Jan 3, 2019
1 parent cf23b9a commit e51b16d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/file-manager/fm-directory-view.c
Expand Up @@ -8811,7 +8811,7 @@ real_update_menus (FMDirectoryView *view)
for (l = selection; l != NULL; l = l->next) {
CajaFile *file;

file = CAJA_FILE (selection->data);
file = CAJA_FILE (l->data);

if (!caja_mime_file_opens_in_external_app (file)) {
show_app = FALSE;
Expand Down

0 comments on commit e51b16d

Please sign in to comment.