Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] An option to enable confirmation on moving (deleting) files to trash #632

Closed
luuuciano opened this Issue Sep 7, 2016 · 11 comments

Comments

Projects
None yet
6 participants
@luuuciano
Copy link

luuuciano commented Sep 7, 2016

Yes, we know... moving a file is not deleting it... ok

But you know too, that mate is used by several kind of people, even kids... so, it is not nice having to check trash every day to see if something was deleted by mistake.
In fact, anyone can hit delete key by mistake in caja having focus, and delete whatever it was there without too much notice... and pushing it for a few seconds will delete (move) a bunch of things. Because files are being selected on every moving, if you do not release the key you will be movingtotrash(deleting) all the files and directories on that level and below

If you find that behavior, moving to trash without confirmation, a nice feature ok, that is great. But let the other people to decide if they want to use it or not...

@luuuciano luuuciano changed the title An option to enable confirmation on moving (deleting) files to trash [FR] An option to enable confirmation on moving (deleting) files to trash Sep 7, 2016

@kn00tcn

This comment has been minimized.

Copy link

kn00tcn commented Oct 26, 2016

i accidentally deleted when trying to push the 'end' button, a confirmation is needed yes (just a duplicate of the existing one on file systems/devices that cant make a .trash folder)

@rpoitevin

This comment has been minimized.

Copy link

rpoitevin commented Nov 18, 2016

Hi!

I up this issue! I teach to blind people how to use a computer and it often happens beginners call me because they lost an icon on the desktop.

Regards.

@cwendling

This comment has been minimized.

Copy link
Contributor

cwendling commented Jan 11, 2017

I think Nautilus "solved" this by displaying a notification and allowing to undo the move (both with a button on the notification and with Ctrl+Z). Not sure how accessible it is, but it's probably a fairly slick default UI, even if there was an additional confirmation option.
It's generally always best to allow undoing, anyone can accidentally validate a confirmation dialog too.

So I'd up this as an easy solution, and suggest trying to implement undoability in the long term :)

@lukefromdc

This comment has been minimized.

Copy link
Member

lukefromdc commented Jan 11, 2017

You can undo moving a file now in Caja with the menubar's edit>undo option. To undo deleting a file(not moved to trash) would be something else altogether, in fact that's a data recovery job for tools like Photorec. Been there, done that.

@kn00tcn

This comment has been minimized.

Copy link

kn00tcn commented Jan 12, 2017

-if the device/partition/filesystem lacks a trash, a confirmation is needed
-if you delete from the desktop, you have to open a new caja window to reach the edit>undo menu, some people wont realize this so undo should show up in the desktop right click menu
-confirmation would be nice in general at all times like my example of my finger missing the end button

(edit: the above list is based on having the trash enabled, actually i feel like a trash lacking drive does warn you, i havent tried to see what happens if you disable the trash & then delete on a trash capable drive)

i dont remember if ctrl+z does anything on the desktop

right now i'm flipping between xfce & mate, disappointed in the glaring issues in both yet certain things are too good to give up, i have no choice but to start developing... this is on top of the need to make a solid gtk+multiple decorators+multiple panels theme

luke, are you implying you have no interest in adding a notification? this sounds like a simple enough thing for me to make as a first attempt, some pointers or tips would certainly be nice though

@lukefromdc

This comment has been minimized.

Copy link
Member

lukefromdc commented Jan 12, 2017

I have limited time-especially now with other things going on in this town. Also, I don't really know where to start on that particular job unless Nemo or Nautilus already have a simiar feature.

@lukefromdc

This comment has been minimized.

Copy link
Member

lukefromdc commented Jan 12, 2017

https://github.com/cwendling , do you know approximately when Nautilus did something like this, or the file that was changed? I would need one or the other to find the commit as Nautilus gets thousands

@cwendling

This comment has been minimized.

Copy link
Contributor

cwendling commented Jan 12, 2017

You can undo moving a file now in Caja with the menubar's edit>undo option.

Oh, indeed, I missed that. That's great :)

To undo deleting a file(not moved to trash) would be something else altogether, in fact that's a data recovery job for tools like Photorec. Been there, done that.

Yeah sure, in the case of permanent deletion it should ask and that's all. It does on Shift+Del, that's good. But apparently it doesn't when trying to move to trash but there's no trash: I tried in a /tmp/ file and it didn't ask, and somewhat confused the undo history that thought it could undo something but couldn't.

@cwendling

This comment has been minimized.

Copy link
Contributor

cwendling commented Jan 12, 2017

@cwendling , do you know approximately when Nautilus did something like this, or the file that was changed?

Not really, sorry. I think it would be around 3.18 or alike, but I'm not sure at all. Maybe check the news file for it, or that author's blog? Sounds like an important enough feature to be listed.

@kn00tcn

This comment has been minimized.

Copy link

kn00tcn commented Jan 12, 2017

if the exact dialogue already exists in shift+del, then it would make sense to reuse that code if a new option of 'always confirm deletion' is added to settings

adding it to my list of things to attempt to work on...

cwendling added a commit to cwendling/caja that referenced this issue Jan 26, 2017

Add an option for asking confirmation before moving files to the trash
Add an option to show a confirmation dialog when moving files to the
trash, like there is for deleting files directly or emptying the trash.

Closes mate-desktop#632.

@monsta monsta closed this in #723 Feb 7, 2017

monsta added a commit that referenced this issue Feb 7, 2017

Add an option for asking confirmation before moving files to the trash
Add an option to show a confirmation dialog when moving files to the
trash, like there is for deleting files directly or emptying the trash.

Closes #632.
@monsta

This comment has been minimized.

Copy link
Member

monsta commented Feb 7, 2017

Ok, this feature is now in, #723 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.