New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caja doesn't use the the right font color in iconview with dark themes #81

Closed
raveit65 opened this Issue Feb 20, 2013 · 14 comments

Comments

Projects
None yet
10 participants
@raveit65
Member

raveit65 commented Feb 20, 2013

If i use use a dark desktop theme caja-1.5.x doesn't displayed the expected white font color for folder names if i used 'iconview' when caja starts.
I see the folder names with black color on dark background.
I can toogle to 'listview' with crtl+2 and the font color is white, than toogle back to 'iconview' with crtl+1 and the fontcolor has the expecected value 'white'.
All sreenshots with gnomishdark

Also i notice, if i switch back to a white theme and a caja window is open, the font color stays on white color with a white caja background in iconview.

This issue happes with all dark themes which i know, (gnomishdark, delorean-dark, anewstartblood, drackfire dreamblack) so i don't think it's a theme issue.
All tested themes working well with caja-1.4.x.
@jasmineaura
Does #72 fix this perhaps?

@tamer-hassan

This comment has been minimized.

Show comment
Hide comment
@tamer-hassan

tamer-hassan Feb 21, 2013

Contributor

I've noticed this too a while back when testing drop colors (from Emblems & Colors dialog), both in the icon canvas area and the "information panel" (left pane). I believe it was an issue pre-existing from 1.4.
Having said that, I don't think that #72 fixes this issue, as that PR was mainly concerned with fixing emblem-layouting inconsistencies and bugs.

Contributor

tamer-hassan commented Feb 21, 2013

I've noticed this too a while back when testing drop colors (from Emblems & Colors dialog), both in the icon canvas area and the "information panel" (left pane). I believe it was an issue pre-existing from 1.4.
Having said that, I don't think that #72 fixes this issue, as that PR was mainly concerned with fixing emblem-layouting inconsistencies and bugs.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Nov 5, 2013

Member

I found a pretty nice workaround until someone start to fix this issue.
The solution is to choose a background color under 'backgrounds/emblems' in edit menu.

  1. open backgrounds/emblems
  2. choose color tap
  3. click on 'add a new color'
  4. use the color picker to select the color from caja-view window part
  5. save the color
  6. drag the new custom color into caja.
    Now caja opens everytime with the right font color in caja-view.
Member

raveit65 commented Nov 5, 2013

I found a pretty nice workaround until someone start to fix this issue.
The solution is to choose a background color under 'backgrounds/emblems' in edit menu.

  1. open backgrounds/emblems
  2. choose color tap
  3. click on 'add a new color'
  4. use the color picker to select the color from caja-view window part
  5. save the color
  6. drag the new custom color into caja.
    Now caja opens everytime with the right font color in caja-view.
@stefano-k

This comment has been minimized.

Show comment
Hide comment
@stefano-k

stefano-k Mar 21, 2014

Member

@NiceandGently is this still an issue?

Member

stefano-k commented Mar 21, 2014

@NiceandGently is this still an issue?

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Mar 21, 2014

Member

Yes, it still exits with 1.8.x.

Member

raveit65 commented Mar 21, 2014

Yes, it still exits with 1.8.x.

@sunweaver

This comment has been minimized.

Show comment
Hide comment
@sunweaver

sunweaver Mar 6, 2015

Member

This has also been reported as debbug#770760.

Member

sunweaver commented Mar 6, 2015

This has also been reported as debbug#770760.

@axalix

This comment has been minimized.

Show comment
Hide comment
@axalix

axalix Mar 20, 2015

I still have this problem. Caja 1.8.2. Linux Mint 17

axalix commented Mar 20, 2015

I still have this problem. Caja 1.8.2. Linux Mint 17

@dcharlespyle

This comment has been minimized.

Show comment
Hide comment
@dcharlespyle

dcharlespyle May 20, 2015

Still happening in mate-desktop 1.8.2, in Fedora 21. As a workaround I used the eyedropper to set the background to the same color as the dark theme (BlackMATE) I am using.

dcharlespyle commented May 20, 2015

Still happening in mate-desktop 1.8.2, in Fedora 21. As a workaround I used the eyedropper to set the background to the same color as the dark theme (BlackMATE) I am using.

@Ralnoc

This comment has been minimized.

Show comment
Hide comment
@Ralnoc

Ralnoc Aug 27, 2015

This is still seen in Fedora 22 running xfce4 with Caja 1.10.2.

A easy workaround is to apply a color background that doesn't conflict with the font coloring through 'Backgrounds and Emblems -> Colors'. You drag a non-conflicting color to the file list and this will address it.

However we should not have to implement a workaround. Caja should honor the correct theme colors provided by the WM.

Ralnoc commented Aug 27, 2015

This is still seen in Fedora 22 running xfce4 with Caja 1.10.2.

A easy workaround is to apply a color background that doesn't conflict with the font coloring through 'Backgrounds and Emblems -> Colors'. You drag a non-conflicting color to the file list and this will address it.

However we should not have to implement a workaround. Caja should honor the correct theme colors provided by the WM.

@luispabon

This comment has been minimized.

Show comment
Hide comment
@luispabon

luispabon Oct 26, 2015

Still an issue on Ubuntu 15.10 + Mate 1.8 (Caja 1.10.4). Open Caja, all fonts are black and unreadable on dark theme. Change from iconview to something else and back, font colour fixed.

luispabon commented Oct 26, 2015

Still an issue on Ubuntu 15.10 + Mate 1.8 (Caja 1.10.4). Open Caja, all fonts are black and unreadable on dark theme. Change from iconview to something else and back, font colour fixed.

@gamax92

This comment has been minimized.

Show comment
Hide comment
@gamax92

gamax92 Dec 18, 2015

Still an issue, font color is black and after changing theme and back, it goes to proper text color. Then after a while I notice it's back to the wrong color.

gamax92 commented Dec 18, 2015

Still an issue, font color is black and after changing theme and back, it goes to proper text color. Then after a while I notice it's back to the wrong color.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Jan 13, 2016

Member

fixed for gtk3

Member

raveit65 commented Jan 13, 2016

fixed for gtk3

@raveit65 raveit65 reopened this Jan 13, 2016

raveit65 pushed a commit that referenced this issue Jan 15, 2016

@raveit65 raveit65 closed this in 1ff3468 Jan 18, 2016

raveit65 pushed a commit that referenced this issue Jan 18, 2016

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Jan 18, 2016

Member

@sunweaver
I've cherry-picked that commit to 1.12 too.
It should be easy too backport to older releases if you need it

Member

raveit65 commented Jan 18, 2016

@sunweaver
I've cherry-picked that commit to 1.12 too.
It should be easy too backport to older releases if you need it

@raveit65 raveit65 reopened this Jan 19, 2016

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Jan 19, 2016

Member

Well there's a regression after all... When using custom background color (you can set it via Emblems & Background dialog), font color isn't changed. E.g. if I select dark bg color and font of my GTK+ theme is black, it will remain black (and thus unreadable).

Tested in GTK+2 build.

Member

raveit65 commented Jan 19, 2016

Well there's a regression after all... When using custom background color (you can set it via Emblems & Background dialog), font color isn't changed. E.g. if I select dark bg color and font of my GTK+ theme is black, it will remain black (and thus unreadable).

Tested in GTK+2 build.

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta Mar 21, 2016

Member

Fixed for GTK+2 as well with #526.

Member

monsta commented Mar 21, 2016

Fixed for GTK+2 as well with #526.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment