New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require GTK+ >= 3.14, drop GTK+2 code and --with-gtk build option #140

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@monsta
Member

monsta commented May 28, 2016

@flexiondotorg @clefebvre @raveit65 @posophe @XRevan86 @willysr @obache @NP-Hardass

Next one... now we move Engrampa to GTK+3 - but with one exception:

Caja extension will be always built with GTK+ version that is used by libcaja-extension. It's autodetected at build time.
It is technically possible because Caja extension doesn't need any code from Engrampa at build time. It only invokes Engrampa binary at runtime.

Other changes are as usual:

  • minimum GTK+ version is set to 3.14
  • GTK+2 code is dropped
  • --with-gtk build option is dropped as well
  • build-dep on GTK+ is changed (that's what you need to do in your distros)
require GTK+ >= 3.14, drop GTK+2 code and --with-gtk build option
one exception: Caja extension will be always built with GTK+ version
that is used by libcaja-extension (it's autodetected at build time)
@willysr

This comment has been minimized.

Show comment
Hide comment
@willysr

willysr May 28, 2016

Member

+1

Member

willysr commented May 28, 2016

+1

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 May 29, 2016

Member

Builds and run fine, tested in gtk+3 environment.

Member

raveit65 commented May 29, 2016

Builds and run fine, tested in gtk+3 environment.

@monsta monsta closed this Jun 1, 2016

@monsta monsta deleted the dev-gtk3-migration branch Jun 1, 2016

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta Jun 1, 2016

Member

Dammit... merged the old version of this branch, with two commits instead of a single squashed one 😄

Member

monsta commented Jun 1, 2016

Dammit... merged the old version of this branch, with two commits instead of a single squashed one 😄

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Jan 18, 2017

app-arch/engrampa: Drop dep on gtk3 for caja
As per mate-desktop/engrampa#140, gtk3 selection
not necessary in engrampa, and is automagically selected based on what caja
has selected.  Handle gtk3 only in caja rather than in engrampa

Package-Manager: portage-2.3.0

gentoo-bot pushed a commit to gentoo/gentoo-mate that referenced this pull request Jan 29, 2017

app-arch/engrampa: Drop dep on gtk3 for caja
As per mate-desktop/engrampa#140, gtk3 selection
not necessary in engrampa, and is automagically selected based on what caja
has selected.  Handle gtk3 only in caja rather than in engrampa

Package-Manager: portage-2.3.0

gentoo-bot pushed a commit to gentoo/gentoo-mate that referenced this pull request Feb 5, 2017

app-arch/engrampa: Drop dep on gtk3 for caja
As per mate-desktop/engrampa#140, gtk3 selection
not necessary in engrampa, and is automagically selected based on what caja
has selected.  Handle gtk3 only in caja rather than in engrampa

Package-Manager: portage-2.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment