require GTK+ >= 3.14, drop GTK+2 code and --with-gtk build option #140

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@monsta
Member
monsta commented May 28, 2016 edited

@flexiondotorg @clefebvre @raveit65 @posophe @XRevan86 @willysr @obache @NP-Hardass

Next one... now we move Engrampa to GTK+3 - but with one exception:

Caja extension will be always built with GTK+ version that is used by libcaja-extension. It's autodetected at build time.
It is technically possible because Caja extension doesn't need any code from Engrampa at build time. It only invokes Engrampa binary at runtime.

Other changes are as usual:

  • minimum GTK+ version is set to 3.14
  • GTK+2 code is dropped
  • --with-gtk build option is dropped as well
  • build-dep on GTK+ is changed (that's what you need to do in your distros)
@monsta monsta require GTK+ >= 3.14, drop GTK+2 code and --with-gtk build option
one exception: Caja extension will be always built with GTK+ version
that is used by libcaja-extension (it's autodetected at build time)
eac4323
@willysr
willysr commented May 28, 2016

+1

@raveit65
Member

Builds and run fine, tested in gtk+3 environment.

@monsta monsta closed this Jun 1, 2016
@monsta monsta deleted the dev-gtk3-migration branch Jun 1, 2016
@monsta
Member
monsta commented Jun 1, 2016

Dammit... merged the old version of this branch, with two commits instead of a single squashed one 😄

@gentoo-bot gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Jan 18, 2017
@NP-Hardass NP-Hardass app-arch/engrampa: Drop dep on gtk3 for caja
As per mate-desktop/engrampa#140, gtk3 selection
not necessary in engrampa, and is automagically selected based on what caja
has selected.  Handle gtk3 only in caja rather than in engrampa

Package-Manager: portage-2.3.0
7f56e5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment