Allow use of arrows while in alt+tab popup #330

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

pldubouilh commented Jun 24, 2017

(issue #182)

Seems to work well.
thank you

Ok, this works for me.

A few notes:

  • would be more descriptive to use defines instead of numbers for the keycodes
  • would be nice to add numpad's left and right keys too

@monsta monsta requested a review from lukefromdc Jun 27, 2017

This works. With it you can use the arrow keys, without it trying to use the arrow keys closes the popup

Member

raveit65 commented Jul 8, 2017

@pldubouilh
We have a open question from core-team member.

Contributor

pldubouilh commented Jul 14, 2017

@monsta @raveit65 I added support for the numpad arrows too, but I don't have such a keyboard at hand so please test it

Member

raveit65 commented Jul 14, 2017

I just tested it. Arrow keys on numpad are usable now.
Thank you

Member

monsta commented Jul 14, 2017

Works fine, but I accidentally noticed a funny thing...
You know that holding Shift in addition to Alt makes Tab switch the windows in reverse order. Guess what, now holding Shift swaps left and right arrows too. 🙂
Are you guys ok with that?

Member

raveit65 commented Jul 14, 2017

The function of holding shift is to reverse something, so from logic point of view this is fine.
And i don't think that someone want to use the arrow keys and shift key at the same time.
We shouldn't make it more complicated with disabling the shift key if the arrow keys are used ;-)
I am OK with current state of PR.

Member

monsta commented Jul 14, 2017

The function of holding shift is to reverse something, so from logic point of view this is fine.

I know, it's just funny how it affects arrow keys 🙂

Member

raveit65 commented Jul 14, 2017

merged
c4750c8
7c69bcf
Thank you

@raveit65 raveit65 closed this Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment