-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trashapplet: Remove animation that hasn't worked in years #659
Conversation
lukefromdc
commented
Aug 14, 2023
•
edited
Loading
edited
Previously we fixed one segfault (in trash) by excluding the conflicting function from in-process builds of the trash applet. With this we remove any potential segfaults caused by any other applet of the panel calling the wrong function. Why the conflicting functions ever worked I do not know, wondering if the older glib version somehow allowed the applet's version of xstuff_zoom_animate() instead of the panel's function of the same name to be called first. This was not a glib bug, but rather a bug in our code revealed by a glib update, as it should never have worked and it it did was working by chance only. |
This will work but if you want avoid similar problems in future then read documentation for P.S. You don't need to change name of static function. |
The crash is gone with using the internal zoom-animation. |
The question is do we want to keep the currently non-working animation around in case someone comes up with a fix for it later, or remove it as it hasn't worked in years. The latter would allow removal of xstuff.c and xstuff.h from the applet's source files, but would complicate any later rewrite aimed at making the trash icon respond to being clicked on. |
+1 for removing. I don't think that someone will fix it because nobody knows that the function exists. |
OK, that's what I will do |
*The trash applet hasn't had working animation in many years *xstuff_zoom_animate also appears in mate-panel with 4 arguments instead of 2. *conflicting function names caused a segfault when built in-process
bace53c
to
58e1cac
Compare
Done, simple revert if ever needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM