Make the build reproducible #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should also be done on the mate-about/meson.build file, otherwise the build won't be reproducible using meson. |
Whilst working on the Reproducible Builds effort [0] we noticed that mate-desktop could not be built reproducibly. This is is because it generated a "release year" etc. based on the current build date which was embedded in the binary and possibly other files. A patch attached that uses SOURCE_DATE_EPOCH [1] instead. As a side-effect, this fixes the (accidental) reset of MATE_DATE in the Autotools build system in inherited from mate-desktop-environment.git. This was originally filed in Debian as #951357 [2]. [0] https://reproducible-builds.org/ [1] https://reproducible-builds.org/specs/source-date-epoch/ [2] https://bugs.debian.org/951357
lamby
force-pushed
the
951357-mate-desktop-please-make-the-build-reproducible
branch
from
731b97f
to
6d8dfce
Compare
|
Sure thing; updated patch attached. |
rbuj
approved these changes
Feb 15, 2020
|
test: Year 2038 problem PASSED Screenshot showing the year 2038:
|
lukefromdc
approved these changes
Feb 16, 2020
There was a problem hiding this comment.
Just got a clean build with meson, and it correctly showed the year 2020 with normal clock settings in mate-about.
Note that being able to reproduce and hash-check builds in general benefits security both by allowing users to confirm builds and because of that deterring malicious persons or organizationbs from distributing builds from covertly altered source.
lamby
deleted the
951357-mate-desktop-please-make-the-build-reproducible
branch
tasmo
pushed a commit
to prototypefund/reproducible-website
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort I noticed that mate-desktop could not be built reproducibly.
This is is because it generated a "release year" based on the current build date which was embedded in the binary and possibly other files. A patch attached that uses SOURCE_DATE_EPOCH instead.
As a side-effect, this fixes the (accidental) reset of
MATE_DATEin the Autotools build system in inherited frommate-desktop-environment.git.This was originally filed in Debian as #951357.