Skip to content

Commit 92910b6

Browse files
committed
avoid deprecated 'gdk_error_trap_push/pop/pop_ignored' and 'gdk_flush'
1 parent 80bc7d7 commit 92910b6

File tree

4 files changed

+25
-19
lines changed

4 files changed

+25
-19
lines changed

maximus/main.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ gint main (gint argc, gchar *argv[])
6464
MaximusApp UNUSED_VARIABLE *app;
6565
GOptionContext *context;
6666
GError *error = NULL;
67+
GdkDisplay *gdk_display = gdk_display_get_default ();
6768

6869
g_set_application_name ("Maximus");
6970

@@ -89,9 +90,9 @@ gint main (gint argc, gchar *argv[])
8990
g_option_context_parse (context, &argc, &argv, NULL);
9091
g_option_context_free(context);
9192

92-
gdk_error_trap_push ();
93+
gdk_x11_display_error_trap_push (gdk_display);
9394
app = maximus_app_get_default ();
94-
gdk_error_trap_pop_ignored ();
95+
gdk_x11_display_error_trap_pop_ignored (gdk_display);
9596

9697
gtk_main ();
9798

maximus/maximus-app.c

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,13 @@ gdk_window_set_mwm_hints (WnckWindow *window,
149149
hints_atom = gdk_x11_get_xatom_by_name_for_display (display,
150150
_XA_MOTIF_WM_HINTS);
151151

152-
gdk_error_trap_push ();
152+
gdk_x11_display_error_trap_push (display);
153153
XGetWindowProperty (GDK_DISPLAY_XDISPLAY (display),
154154
wnck_window_get_xid (window),
155155
hints_atom, 0, sizeof (MotifWmHints)/sizeof (long),
156156
False, AnyPropertyType, &type, &format, &nitems,
157157
&bytes_after, &data);
158-
if (gdk_error_trap_pop ())
158+
if (gdk_x11_display_error_trap_pop (display))
159159
return;
160160

161161
if (type != hints_atom || !data)
@@ -181,7 +181,7 @@ gdk_window_set_mwm_hints (WnckWindow *window,
181181
wnck_window_get_xid (window),
182182
hints_atom, hints_atom, 32, PropModeReplace,
183183
(guchar *)hints, sizeof (MotifWmHints)/sizeof (long));
184-
gdk_flush ();
184+
gdk_display_flush (display);
185185
_wnck_error_trap_pop ();
186186

187187
if (data)
@@ -359,6 +359,7 @@ on_window_opened (WnckScreen *screen,
359359
MaximusAppPrivate *priv;
360360
WnckWindowType type;
361361
gint exclude = 0;
362+
GdkDisplay *gdk_display = gdk_display_get_default ();
362363

363364
g_return_if_fail (MAXIMUS_IS_APP (app));
364365
g_return_if_fail (WNCK_IS_WINDOW (window));
@@ -369,9 +370,9 @@ on_window_opened (WnckScreen *screen,
369370
return;
370371

371372
/* Ignore undecorated windows */
372-
gdk_error_trap_push ();
373+
gdk_x11_display_error_trap_push (gdk_display);
373374
exclude = wnck_window_is_decorated (window) ? 0 : 1;
374-
if (gdk_error_trap_pop ())
375+
if (gdk_x11_display_error_trap_pop (gdk_display))
375376
return;
376377

377378
if (wnck_window_is_maximized (window))
@@ -390,7 +391,7 @@ on_window_opened (WnckScreen *screen,
390391
if (wnck_window_is_maximized(window) && priv->undecorate)
391392
{
392393
_window_set_decorations (window, 0);
393-
gdk_flush ();
394+
gdk_display_flush (gdk_display);
394395
}
395396
g_signal_connect (window, "state-changed",
396397
G_CALLBACK (on_window_state_changed), app);
@@ -403,7 +404,7 @@ on_window_opened (WnckScreen *screen,
403404
if (!window_is_too_large_for_screen (window))
404405
{
405406
_window_set_decorations (window, 0);
406-
gdk_flush ();
407+
gdk_display_flush (gdk_display);
407408
}
408409
}
409410

@@ -483,12 +484,14 @@ on_app_undecorate_changed (GSettings *settings,
483484

484485
if (!is_excluded (app, window))
485486
{
486-
gdk_error_trap_push ();
487+
GdkDisplay *gdk_display = gdk_display_get_default ();
488+
489+
gdk_x11_display_error_trap_push (gdk_display);
487490
_window_set_decorations (window, priv->undecorate ? 0 : 1);
488491
wnck_window_unmaximize (window);
489492
wnck_window_maximize (window);
490-
gdk_flush ();
491-
gdk_error_trap_pop_ignored ();
493+
gdk_display_flush (gdk_display);
494+
gdk_x11_display_error_trap_pop_ignored (gdk_display);
492495

493496
sleep (1);
494497
}

maximus/tomboykeybinder.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ grab_ungrab_with_ignorable_modifiers (GdkWindow *rootwin,
102102
static gboolean
103103
do_grab_key (Binding *binding)
104104
{
105-
GdkKeymap *keymap = gdk_keymap_get_for_display (gdk_display_get_default ());
105+
GdkDisplay *gdk_display = gdk_display_get_default ();
106+
GdkKeymap *keymap = gdk_keymap_get_for_display (gdk_display);
106107
GdkWindow *rootwin = gdk_get_default_root_window ();
107108

108109
EggVirtualModifierType virtual_mods = 0;
@@ -131,15 +132,15 @@ do_grab_key (Binding *binding)
131132

132133
TRACE (g_print ("Got modmask %d\n", binding->modifiers));
133134

134-
gdk_error_trap_push ();
135+
gdk_x11_display_error_trap_push (gdk_display);
135136

136137
grab_ungrab_with_ignorable_modifiers (rootwin,
137138
binding,
138139
TRUE /* grab */);
139140

140-
gdk_flush ();
141+
gdk_display_flush (gdk_display);
141142

142-
if (gdk_error_trap_pop ()) {
143+
if (gdk_x11_display_error_trap_pop (gdk_display)) {
143144
g_warning ("Binding '%s' failed!\n", binding->keystring);
144145
return FALSE;
145146
}

maximus/xutils.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,15 @@
3737
void
3838
_wnck_error_trap_push (void)
3939
{
40-
gdk_error_trap_push ();
40+
gdk_x11_display_error_trap_push (gdk_display_get_default ());
4141
}
4242

4343
int
4444
_wnck_error_trap_pop (void)
4545
{
46-
XSync (GDK_DISPLAY_XDISPLAY (gdk_display_get_default ()), False);
47-
return gdk_error_trap_pop ();
46+
GdkDisplay *gdk_display = gdk_display_get_default ();
47+
XSync (GDK_DISPLAY_XDISPLAY (gdk_display), False);
48+
return gdk_x11_display_error_trap_pop (gdk_display);
4849
}
4950

5051
static char*

0 commit comments

Comments
 (0)