New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

require GTK+ >= 3.14, drop GTK+2 code and --with-gtk build option #102

Merged
merged 4 commits into from May 26, 2016

Conversation

Projects
None yet
4 participants
@monsta
Member

monsta commented May 20, 2016

@flexiondotorg @clefebvre @raveit65 @posophe @XRevan86 @willysr @obache @NP-Hardass

And now we move m-n-d to GTK+3:

  • minimum GTK+ version is set to 3.14
  • GTK+2 code and deprecated GTK+3 code are dropped
  • --with-gtk build option is dropped as well
  • build-deps on GTK+, wnck and canberra dev packages are changed (that's what you need to do in your distros)

For example, in Debian/Ubuntu build-deps are changed as follows:
libcanberra-gtk-dev -> libcanberra-gtk3-dev
libgtk2.0-dev -> libgtk-3-dev
libwnck-dev -> libwnck-3-dev

Also please note that slider theme doesn't use reversed colors from GTK+ theme anymore. It uses your fg/bg as is. I understand it might be a surprise for some users, but we couldn't manage to get the color reversing to work with all GTK+ 3.xx versions out there. And honestly... did this reversing make sense really? 馃槃

@flexiondotorg

This comment has been minimized.

Show comment
Hide comment
@flexiondotorg
Member

flexiondotorg commented May 21, 2016

+1

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 May 21, 2016

Member

Looks like people thinks this is a voting 馃槃
...i think @monsta wants that people test the commit.
...building.......installation.......runtime 馃槈

Member

raveit65 commented May 21, 2016

Looks like people thinks this is a voting 馃槃
...i think @monsta wants that people test the commit.
...building.......installation.......runtime 馃槈

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta May 21, 2016

Member

It's also a notification for distro maintainers so they won't get a surprise when 1.16 is released 馃槃

Member

monsta commented May 21, 2016

It's also a notification for distro maintainers so they won't get a surprise when 1.16 is released 馃槃

@lukefromdc

This comment has been minimized.

Show comment
Hide comment
@lukefromdc

lukefromdc May 23, 2016

Member

Works fine over here

Member

lukefromdc commented May 23, 2016

Works fine over here

@monsta monsta merged commit c1cb767 into master May 26, 2016

@monsta monsta deleted the dev-gtk3-migration branch May 26, 2016

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta May 26, 2016

Member

We still need to fix #98 before 1.16 release, so if anyone of you guys can help with that, please comment there.

Member

monsta commented May 26, 2016

We still need to fix #98 before 1.16 release, so if anyone of you guys can help with that, please comment there.

@lukefromdc

This comment has been minimized.

Show comment
Hide comment
@lukefromdc

lukefromdc May 26, 2016

Member

Fixing that would require a full-on cairo copy of the background and cairo
draw of the window over it, I don't know how to do that.

On 5/26/2016 at 4:27 AM, "monsta" notifications@github.com wrote:

We still need to fix #98 before 1.16 release, so if anyone of you
guys can help with that, please comment there.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-notification-
daemon/pull/102#issuecomment-221809052

Member

lukefromdc commented May 26, 2016

Fixing that would require a full-on cairo copy of the background and cairo
draw of the window over it, I don't know how to do that.

On 5/26/2016 at 4:27 AM, "monsta" notifications@github.com wrote:

We still need to fix #98 before 1.16 release, so if anyone of you
guys can help with that, please comment there.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-notification-
daemon/pull/102#issuecomment-221809052

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta May 26, 2016

Member

By any chance, maybe some app already has this implemented?

Member

monsta commented May 26, 2016

By any chance, maybe some app already has this implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment