Patched panel-profile.c to have multiple Xscreens work. #228

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@axelolmos

For newer versions of the panel, if you have multiple X screens, that is to say:
DISPLAY=:0.0 DISPLAY=:0.1 the panel will create two menus on screen 0, and none on screen 1.

The desired behavior is one menu per X screen. This gets very important if you are running multiple video cards and multiple monitors.

When running only one X screen this patch shouldn't matter.

The stacking of menus and icons on the first screen has been happening since the gnome-panel >2.1 days. It happens on anything that forked off of newer versions of Gnome 2.

This patch, although crudely written, restores the desired behavior.
Please modify it to your content and apply it to all versions of the panel.

Thank You.

Axel Olmos
Patched panel-profile.c to have multiple Xscreens work.
(Instead of having all the icons and menus stack on :0.0)
@thenewguy

This comment has been minimized.

Show comment
Hide comment
@thenewguy

thenewguy May 6, 2015

Any chance of this being fixed?

Any chance of this being fixed?

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 May 20, 2015

Member

@monsta
Can you please review this long outstanding PR ?

Member

raveit65 commented May 20, 2015

@monsta
Can you please review this long outstanding PR ?

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta May 21, 2015

Member

In #149 the menubar is mentioned only as example:

However, any interaction with the widgets on the second screen shows up on the first screen rather than the second.

So what if the widget is a clock, for example? Or a volume control applet?
I look at the code here and don't see anything for that.

Member

monsta commented May 21, 2015

In #149 the menubar is mentioned only as example:

However, any interaction with the widgets on the second screen shows up on the first screen rather than the second.

So what if the widget is a clock, for example? Or a volume control applet?
I look at the code here and don't see anything for that.

@axelolmos

This comment has been minimized.

Show comment
Hide comment
@axelolmos

axelolmos May 21, 2015

I created this web page to illustrate the issue:
http://www.olmosconsulting.com/mate-panel

There's documentation there as to the nature of the problem, and how I solved it.

The easiest way to get a handle on this is have two monitors on your PC, and set up your xorg.conf so that you have two screens. I have a sample xorg.conf where I do 16 screens at: http://www.olmosconsulting.com/mate-panel/xorg.conf

The code I submitted is a hack. I simply made a guess as to what was going on, and tried to fix it. When it worked the way I expected, I stopped writing.

That being said, the ability to use multiple video cards and multiple monitors with separate screens has been a feature of Unix / Linux operating systems running X / Xorg for decades. It shouldn't die because of bug in an application higher up on the stack.

I created this web page to illustrate the issue:
http://www.olmosconsulting.com/mate-panel

There's documentation there as to the nature of the problem, and how I solved it.

The easiest way to get a handle on this is have two monitors on your PC, and set up your xorg.conf so that you have two screens. I have a sample xorg.conf where I do 16 screens at: http://www.olmosconsulting.com/mate-panel/xorg.conf

The code I submitted is a hack. I simply made a guess as to what was going on, and tried to fix it. When it worked the way I expected, I stopped writing.

That being said, the ability to use multiple video cards and multiple monitors with separate screens has been a feature of Unix / Linux operating systems running X / Xorg for decades. It shouldn't die because of bug in an application higher up on the stack.

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta May 27, 2015

Member

The code I submitted is a hack.

That's why we can't accept it as is. We need some more generic solution.

/* We make the possibly wrong assumption that each screen only has one menu bar
   This is how we know to increment the screen number.  */

What if there's no classic menubar at all?

linuxmint-mate

Member

monsta commented May 27, 2015

The code I submitted is a hack.

That's why we can't accept it as is. We need some more generic solution.

/* We make the possibly wrong assumption that each screen only has one menu bar
   This is how we know to increment the screen number.  */

What if there's no classic menubar at all?

linuxmint-mate

@monsta monsta closed this Jun 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment