New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSettings key for icon sizes, change default menubar icon size to 22px + some fixes #406

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@XRevan86
Contributor

XRevan86 commented Feb 13, 2016

  • Add a GSchema for changing icon size of menubar icon and menu item icons.
  • Default menubar icon is too big for a 24px panel as it touches the panel borders, so make it 22px.
  • Fix Gtk 3.16+ dishonouring mate-panel's defaults on menu icons size.
  • Also I cleaned code around icon loading a bit, fixed some warnings.
@Exalm

This comment has been minimized.

Show comment
Hide comment
@Exalm

Exalm Feb 14, 2016

Doesn't work on GTK2 build of 1.12.1. The patch applies cleanly, and it seems to lag less (or perhaps it's just me?), but the lag is still noticeable. And the memory usage is actually higher with the patch (68mb instead of 53mb).

Also the menubar icon becomes smaller:
default

Ok, for some reason manually built version consumes more memory than the default one. When compared with a built version without the patch, it just does nothing except the menubar icon thing.

Exalm commented Feb 14, 2016

Doesn't work on GTK2 build of 1.12.1. The patch applies cleanly, and it seems to lag less (or perhaps it's just me?), but the lag is still noticeable. And the memory usage is actually higher with the patch (68mb instead of 53mb).

Also the menubar icon becomes smaller:
default

Ok, for some reason manually built version consumes more memory than the default one. When compared with a built version without the patch, it just does nothing except the menubar icon thing.

@XRevan86 XRevan86 changed the title from Possible fix for #75 to Change default menubar icon size to 22px + some fixes Feb 16, 2016

XRevan86 added some commits Feb 15, 2016

merge panel_load_menu_image_deferred() into setup_menuitem_with_icon()
also rename setup_menu_item_with_icon() to setup_menuitem_with_icon(),
and drop GtkStock support from it

@XRevan86 XRevan86 changed the title from Change default menubar icon size to 22px + some fixes to GSettings key for icon sizes, change default menubar icon size to 22px + some fixes Feb 20, 2016

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Feb 21, 2016

Member

Works great with MATE GTK+2 on fedora rawhide, nice feature 😃
With MATE GTK+3.16 on fedora 22 changing menuitem size works great too,
only changing menubar icon size does not have any effect.
Not shure if this related to this PR.

....... great job
@monsta please test it too

Member

raveit65 commented Feb 21, 2016

Works great with MATE GTK+2 on fedora rawhide, nice feature 😃
With MATE GTK+3.16 on fedora 22 changing menuitem size works great too,
only changing menubar icon size does not have any effect.
Not shure if this related to this PR.

....... great job
@monsta please test it too

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Feb 21, 2016

Member

Ok, it works well in gtk3 too, now :)
@monsta
i will merge it because i will make a 1.13.x release today.
We can always fix something in development phase.

Member

raveit65 commented Feb 21, 2016

Ok, it works well in gtk3 too, now :)
@monsta
i will merge it because i will make a 1.13.x release today.
We can always fix something in development phase.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Feb 21, 2016

Member

merged
bd3d7bc
c29a88f
22c04b8
a0a5912
44a6c2f

Thanks a lot :)

Member

raveit65 commented Feb 21, 2016

merged
bd3d7bc
c29a88f
22c04b8
a0a5912
44a6c2f

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment