New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't lose focus when displaying password prompt dialog #22

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@monsta
Member

monsta commented Aug 18, 2015

fixes #19
fixes mate-desktop/marco#117

thanks to Jeffrey Knockel
(see https://bugzilla.gnome.org/676076 and https://bugs.launchpad.net/bugs/946171)

@flexiondotorg @NiceandGently @infirit
Please test if it fixes the problem on your machines. Steps to reproduce are in:

I'll be testing it here with Marco, but would also like to gather test results with other WMs (e.g. xfwm4 or compiz). Some of these WMs don't trigger the issue at all, I'd just like to make sure there are no regressions with them.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Aug 19, 2015

Member

works!

Member

raveit65 commented Aug 19, 2015

works!

@flexiondotorg

This comment has been minimized.

Show comment
Hide comment
@flexiondotorg

flexiondotorg Aug 19, 2015

Member

Confirmed.

Member

flexiondotorg commented Aug 19, 2015

Confirmed.

@infirit

This comment has been minimized.

Show comment
Hide comment
@infirit

infirit Aug 31, 2015

Contributor

I think gtk_get_current_event_time () or GDK_CURRENT_TIME fit better here, preferably the former.

Contributor

infirit commented Aug 31, 2015

I think gtk_get_current_event_time () or GDK_CURRENT_TIME fit better here, preferably the former.

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta Sep 1, 2015

Member

Does it work better?

Member

monsta commented Sep 1, 2015

Does it work better?

@infirit

This comment has been minimized.

Show comment
Hide comment
@infirit

infirit Sep 1, 2015

Contributor

Ok, it seems gtk_get_current_event_time does not work that well.. merged

Contributor

infirit commented Sep 1, 2015

Ok, it seems gtk_get_current_event_time does not work that well.. merged

@infirit infirit closed this Sep 1, 2015

@monsta monsta deleted the monsta:focus-pocus branch Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment