New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require GTK+ >= 3.14, drop GTK+2 code and --with-gtk build option #28

Merged
merged 1 commit into from May 26, 2016

Conversation

Projects
None yet
5 participants
@monsta
Member

monsta commented May 18, 2016

@flexiondotorg @clefebvre @raveit65 @posophe @XRevan86 @willysr @obache @NP-Hardass

And now we move mate-polkit to GTK+3:

  • minimum GTK+ version is set to 3.14
  • GTK+2 code and deprecated GTK+3 code are dropped
  • --with-gtk build option is dropped as well
  • build-deps on GTK+ and appindicator dev packages are changed (that's what you need to do in your distros)

For example, in Debian/Ubuntu build-deps are changed as follows:
libappindicator-dev -> libappindicator3-dev
libgtk2.0-dev -> libgtk-3-dev

@willysr

This comment has been minimized.

Show comment
Hide comment
@willysr

willysr May 18, 2016

Member

+1 from me

Member

willysr commented May 18, 2016

+1 from me

@flexiondotorg

This comment has been minimized.

Show comment
Hide comment
@flexiondotorg
Member

flexiondotorg commented May 21, 2016

+1

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 May 21, 2016

Member

Looks like people thinks this is a voting 😄
...i think @monsta wants that people test the commit.
...building.......installation.......runtime 😉

Member

raveit65 commented May 21, 2016

Looks like people thinks this is a voting 😄
...i think @monsta wants that people test the commit.
...building.......installation.......runtime 😉

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta May 21, 2016

Member

It's also a notification for distro maintainers so they won't get a surprise when 1.16 is released 😄

Member

monsta commented May 21, 2016

It's also a notification for distro maintainers so they won't get a surprise when 1.16 is released 😄

@lukefromdc

This comment has been minimized.

Show comment
Hide comment
@lukefromdc

lukefromdc May 23, 2016

Member

Tested and works here, clicked on an internal volume in the Caja sidebar and the pasword dialog worked normally and was able to give permission to mount the drive.

Member

lukefromdc commented May 23, 2016

Tested and works here, clicked on an internal volume in the Caja sidebar and the pasword dialog worked normally and was able to give permission to mount the drive.

@monsta monsta merged commit a9222b1 into master May 26, 2016

@monsta monsta deleted the dev-gtk3-migration branch May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment