New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop polkitgtkmate library and its docs #39

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
3 participants
@monsta
Member

monsta commented Dec 15, 2017

it contains only PolkitLockButton widget which nobody uses by now
and GTK+3 already has GtkLockButton

same as done upstream long ago:
https://git.gnome.org/browse/PolicyKit-gnome/commit/?id=1340926a935b60b2b605a8d0d9b256e3a83c3d7d
https://git.gnome.org/browse/PolicyKit-gnome/commit/?id=b8d700121941bb1f032b95c428d2e52a11c5d330

@lukefromdc

Works fine here. Looks like this gets rid of a lot of unused code with no change in behavior. Mounting an internal volume, unmounting it, the password dialog, and dropping priviliges work same as before.

@monsta

This comment has been minimized.

Member

monsta commented Dec 16, 2017

Yes, the polkit agent executable should work as before. It doesn't use this library. The library is only needed when you want to place an "unlock privileges" button in your app, but now there's GtkLockButton for that.

@lukefromdc

This comment has been minimized.

Member

lukefromdc commented Dec 17, 2017

Do any of our applications (such as configuring the panel clock) that have such an unlock button use the old PolkitLockButton widget? If not we should be able to drop this without issue

@monsta

This comment has been minimized.

Member

monsta commented Dec 17, 2017

No, our apps don't use it.

@lukefromdc

This comment has been minimized.

Member

lukefromdc commented Dec 17, 2017

Than this should be ready to go

@raveit65

works out of box, no regression noticed.

@monsta monsta merged commit d87d54b into master Dec 22, 2017

@monsta monsta deleted the drop-polkitgtkmate branch Dec 22, 2017

@raveit65

This comment has been minimized.

Member

raveit65 commented on d87d54b Jan 28, 2018

@monsta
I noticed during building 1.20 tarball that Gir is removed, right?
So i removed dependencies from rpm SPEC file.
But why shows configure the message?

checking for POLKIT_GOBJECT... yes

This comment has been minimized.

Member

raveit65 replied Jan 28, 2018

Ok this check seems to be for
POLKIT_GOBJECT_REQUIRED=0.97
from polkit itself.
But is it fine to build w/o those dependencies?
BuildRequires: gobject-introspection-devel
BuildRequires: cairo-gobject-devel

This comment has been minimized.

Member

monsta replied Jan 28, 2018

Probably yes - I don't see the checks for these two in configure.ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment