Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-up 5d4416a to solve lock by-passing #167

Merged
merged 1 commit into from Aug 24, 2018

Conversation

XRevan86
Copy link
Contributor

Finally this burden has been released from my shoulders :-).

@lukefromdc lukefromdc self-requested a review August 22, 2018 03:43
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I could not duplicate #155 with lightdm and GTK 3.23(Lightdm probable issue as I get no unlocking dialog), this built fine and showed the screensaver images same as before. Unfortunately that was all I was able to test successfully, even on a new session startup

@lukefromdc lukefromdc requested a review from a team August 22, 2018 03:48
@raveit65
Copy link
Member

It fixes the lockscreen issue but scaling (HIDPI) support is broken. The quarter-tile-issue is back
Without PR:
mate-lockscreen
With PR:
mate-lockscreen-2

@raveit65
Copy link
Member

It seems to be working fine on my laptop with non-hidpi display and external monitor at non-hidpi hdmi port.
But i wasn't never able to reproduce the lockscreen issue with my notebook.

@raveit65
Copy link
Member

As far i know the scaling of the background was done with

-	width = WidthOfScreen (gdk_x11_screen_get_xscreen (screen)) / scale;
-	height = HeightOfScreen (gdk_x11_screen_get_xscreen (screen)) / scale;

@vkareh ^^^^^ Am i right?

@XRevan86
Copy link
Contributor Author

@raveit65 Sorry about that. That was trivially fixed.

Copy link
Member

@vkareh vkareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the lock screen by-passing for me! The HiDPI background seems to be fixed now as well.

@vkareh vkareh requested a review from a team August 24, 2018 04:54
Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, lockscreen can't be by-passed any more and HIDPI support works well.
Tested with:

  1. workstation with 2 external monitors (HIDPI at display port + non-HIDPI at hdmi port)
  2. noteboook with 1 external monitor at hdmi port

Thanks for your work, please claim the bounty which will help a bit to replace your damaged hardware.
We need your expertise for fixing bugs.

@raveit65 raveit65 merged commit dbd37df into mate-desktop:master Aug 24, 2018
@sc0w
Copy link
Member

sc0w commented Aug 24, 2018

bounty?

the issue mentioned in the commit message has no bounty (#126)

typo?

I noticed one commit with the issue #155 in the commit message (it isn't in this PR): XRevan86@cbf2d60

but.. the commits XRevan86@8c17c27 and XRevan86@cbf2d60 are different!

@XRevan86
Copy link
Contributor Author

@sc0w It is all the same issue, so I changed the bugreport ID to avoid the commit being mentioned twice by GitHub.

@raveit65
Copy link
Member

@sc0w
i see a bounty #155

@sc0w
Copy link
Member

sc0w commented Aug 24, 2018

@XRevan86 ok, I closed the issue, now you can claim the bounty :)

@XRevan86
Copy link
Contributor Author

@sc0w, yeah, about that…

Thanks for your work, please claim the bounty which will help a bit to replace your damaged hardware.
We need your expertise for fixing bugs.

@raveit65, thanks, I do need the money, but I cannot claim the bounty for a problem that I caused myself, I just can't.

You can claim it in favour of the MATE project if such a thing is possible, I give my permission :-).

@monsta
Copy link
Contributor

monsta commented Sep 22, 2018

Should we close #170 too? I think it's related and should be fixed by this PR.

@XRevan86
Copy link
Contributor Author

@monsta, yes, it is most likely the same bug.

@sunweaver
Copy link
Member

This is the fix for CVE-2018-20681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants