New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-up 5d4416a to solve lock by-passing #167
Conversation
This is a follow-up to 5d4416a to fix mate-desktop#126
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I could not duplicate #155 with lightdm and GTK 3.23(Lightdm probable issue as I get no unlocking dialog), this built fine and showed the screensaver images same as before. Unfortunately that was all I was able to test successfully, even on a new session startup
|
It seems to be working fine on my laptop with non-hidpi display and external monitor at non-hidpi hdmi port. |
|
As far i know the scaling of the background was done with @vkareh ^^^^^ Am i right? |
cbf2d60
to
8c17c27
Compare
|
@raveit65 Sorry about that. That was trivially fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the lock screen by-passing for me! The HiDPI background seems to be fixed now as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well, lockscreen can't be by-passed any more and HIDPI support works well.
Tested with:
- workstation with 2 external monitors (HIDPI at display port + non-HIDPI at hdmi port)
- noteboook with 1 external monitor at hdmi port
Thanks for your work, please claim the bounty which will help a bit to replace your damaged hardware.
We need your expertise for fixing bugs.
|
bounty? the issue mentioned in the commit message has no bounty (#126) typo? I noticed one commit with the issue #155 in the commit message (it isn't in this PR): XRevan86@cbf2d60 but.. the commits XRevan86@8c17c27 and XRevan86@cbf2d60 are different! |
|
@sc0w It is all the same issue, so I changed the bugreport ID to avoid the commit being mentioned twice by GitHub. |
|
@XRevan86 ok, I closed the issue, now you can claim the bounty :) |
|
@sc0w, yeah, about that…
@raveit65, thanks, I do need the money, but I cannot claim the bounty for a problem that I caused myself, I just can't. You can claim it in favour of the MATE project if such a thing is possible, I give my permission :-). |
|
Should we close #170 too? I think it's related and should be fixed by this PR. |
|
@monsta, yes, it is most likely the same bug. |
|
This is the fix for CVE-2018-20681 |
Finally this burden has been released from my shoulders :-).