Skip to content

Commit 7d65c47

Browse files
author
raveit65
committed
a11y-keyboard-manager: replace deprecated gdk_error_trap_push/pop
1 parent 6ae456c commit 7d65c47

File tree

1 file changed

+27
-15
lines changed

1 file changed

+27
-15
lines changed

plugins/a11y-keyboard/msd-a11y-keyboard-manager.c

Lines changed: 27 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ static void
128128
set_devicepresence_handler (MsdA11yKeyboardManager *manager)
129129
{
130130
Display *display;
131+
GdkDisplay *gdk_display;
131132
XEventClass class_presence;
132133
G_GNUC_UNUSED int xi_presence;
133134

@@ -136,7 +137,9 @@ set_devicepresence_handler (MsdA11yKeyboardManager *manager)
136137

137138
display = gdk_x11_get_default_xdisplay ();
138139

139-
gdk_error_trap_push ();
140+
gdk_display = gdk_display_get_default ();
141+
142+
gdk_x11_display_error_trap_push (gdk_display);
140143
DevicePresence (display, xi_presence, class_presence);
141144
/* FIXME:
142145
* Note that this might overwrite other events, see:
@@ -146,8 +149,8 @@ set_devicepresence_handler (MsdA11yKeyboardManager *manager)
146149
RootWindow (display, DefaultScreen (display)),
147150
&class_presence, 1);
148151

149-
gdk_flush ();
150-
if (!gdk_error_trap_pop ())
152+
gdk_display_flush (gdk_display);
153+
if (!gdk_x11_display_error_trap_pop (gdk_display))
151154
gdk_window_add_filter (NULL, devicepresence_filter, manager);
152155
}
153156

@@ -171,16 +174,19 @@ xkb_enabled (MsdA11yKeyboardManager *manager)
171174
static XkbDescRec *
172175
get_xkb_desc_rec (MsdA11yKeyboardManager *manager)
173176
{
177+
GdkDisplay *display;
174178
XkbDescRec *desc;
175179
Status status = Success;
176180

177-
gdk_error_trap_push ();
178-
desc = XkbGetMap (GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), XkbAllMapComponentsMask, XkbUseCoreKbd);
181+
display = gdk_display_get_default ();
182+
183+
gdk_x11_display_error_trap_push (display);
184+
desc = XkbGetMap (GDK_DISPLAY_XDISPLAY(display), XkbAllMapComponentsMask, XkbUseCoreKbd);
179185
if (desc != NULL) {
180186
desc->ctrls = NULL;
181-
status = XkbGetControls (GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), XkbAllControlsMask, desc);
187+
status = XkbGetControls (GDK_DISPLAY_XDISPLAY(display), XkbAllControlsMask, desc);
182188
}
183-
gdk_error_trap_pop_ignored ();
189+
gdk_x11_display_error_trap_pop_ignored (display);
184190

185191
g_return_val_if_fail (desc != NULL, NULL);
186192
g_return_val_if_fail (desc->ctrls != NULL, NULL);
@@ -260,6 +266,7 @@ set_server_from_settings (MsdA11yKeyboardManager *manager)
260266
{
261267
XkbDescRec *desc;
262268
gboolean enable_accessX;
269+
GdkDisplay *display;
263270

264271
mate_settings_profile_start (NULL);
265272

@@ -371,8 +378,10 @@ set_server_from_settings (MsdA11yKeyboardManager *manager)
371378
g_debug ("CHANGE to : 0x%x (2)", desc->ctrls->ax_options);
372379
*/
373380

374-
gdk_error_trap_push ();
375-
XkbSetControls (GDK_DISPLAY_XDISPLAY(gdk_display_get_default()),
381+
display = gdk_display_get_default ();
382+
383+
gdk_x11_display_error_trap_push (display);
384+
XkbSetControls (GDK_DISPLAY_XDISPLAY(display),
376385
XkbSlowKeysMask |
377386
XkbBounceKeysMask |
378387
XkbStickyKeysMask |
@@ -386,8 +395,8 @@ set_server_from_settings (MsdA11yKeyboardManager *manager)
386395

387396
XkbFreeKeyboard (desc, XkbAllComponentsMask, True);
388397

389-
XSync (GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), FALSE);
390-
gdk_error_trap_pop_ignored ();
398+
XSync (GDK_DISPLAY_XDISPLAY(display), FALSE);
399+
gdk_x11_display_error_trap_pop_ignored (display);
391400

392401
mate_settings_profile_end (NULL);
393402
}
@@ -1043,8 +1052,11 @@ msd_a11y_keyboard_manager_start (MsdA11yKeyboardManager *manager,
10431052
static void
10441053
restore_server_xkb_config (MsdA11yKeyboardManager *manager)
10451054
{
1046-
gdk_error_trap_push ();
1047-
XkbSetControls (GDK_DISPLAY_XDISPLAY(gdk_display_get_default()),
1055+
GdkDisplay *display;
1056+
1057+
display = gdk_display_get_default ();
1058+
gdk_x11_display_error_trap_push (display);
1059+
XkbSetControls (GDK_DISPLAY_XDISPLAY(display),
10481060
XkbSlowKeysMask |
10491061
XkbBounceKeysMask |
10501062
XkbStickyKeysMask |
@@ -1059,8 +1071,8 @@ restore_server_xkb_config (MsdA11yKeyboardManager *manager)
10591071
XkbFreeKeyboard (manager->priv->original_xkb_desc,
10601072
XkbAllComponentsMask, True);
10611073

1062-
XSync (GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), FALSE);
1063-
gdk_error_trap_pop_ignored ();
1074+
XSync (GDK_DISPLAY_XDISPLAY(display), FALSE);
1075+
gdk_x11_display_error_trap_pop_ignored (display);
10641076

10651077
manager->priv->original_xkb_desc = NULL;
10661078
}

0 commit comments

Comments
 (0)