run gksu binary instead of loading libgksu2.so (which is GTK+2 only) #81

Merged
merged 1 commit into from Mar 24, 2016

Projects

None yet

4 participants

@monsta
Member
monsta commented Mar 21, 2016

This will avoid crashing when trying to kill/renice another user's process. We can't load symbols from libgksu2.so anymore as m-s-m is GTK+3 only now.

How to test: select "All Processes" in View menu, then right-click on another user's process and try to renice it. You should see gksu dialog appearing. Well, you can try testing it with kill as well, but that's at your own risk. 😄

@flexiondotorg @clefebvre @raveit65 @posophe @XRevan86 @willysr @obache
Note: if m-s-m package in your distros depends on/recommends/suggests libgksu2, it should be changed to gksu after this.

@willysr
willysr commented Mar 21, 2016

is this for 1.12 or 1.14?
since i will be going with 1.12 for Slackware 14.2, i can have more time to test 1.14 whether i will go with a mixed build of GTK+2 and GTK+3 or go with all GTK+3 build only.

@XRevan86
Member

Maybe additionally xdg-su support :-)?

xdg-su -c 'foo --bar "1 2 3"'
@monsta
Member
monsta commented Mar 21, 2016

@willysr: it's for 1.14 (where m-s-m is GTK+3 only).

@XRevan86: pull requests are welcome as usual 😄

@willysr
willysr commented Mar 21, 2016

that's good news (for me) :)

@XRevan86
Member

@monsta, it's no problem to implement but I guess I'll have to wait for this merge request to get merged.

@raveit65
Member

Fedora does not use gksu or libgksu2.so.
We use beesu.
If i try to kill a process of another user i get simply a message that this isn't allowed 😄
So i can't test this.

@raveit65
Member

Using polkit /usr/bin/pkexec would be great.

@monsta
Member
monsta commented Mar 21, 2016

I was going to add pkexec support from upstream but that looks like a bit more work than this. I'll add it later, but not sure if I'll do it in time for 1.14.

@raveit65
Member

Np, it was never a problem in fedora, no reports about.
...for fedora it's more a new feature :)
Better we focus our work on existings PRs for 1.14

@monsta monsta merged commit 6e0ddb9 into master Mar 24, 2016
@monsta monsta deleted the dev-gksu branch Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment