New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

run gksu binary instead of loading libgksu2.so (which is GTK+2 only) #81

Merged
merged 1 commit into from Mar 24, 2016

Conversation

Projects
None yet
4 participants
@monsta
Member

monsta commented Mar 21, 2016

This will avoid crashing when trying to kill/renice another user's process. We can't load symbols from libgksu2.so anymore as m-s-m is GTK+3 only now.

How to test: select "All Processes" in View menu, then right-click on another user's process and try to renice it. You should see gksu dialog appearing. Well, you can try testing it with kill as well, but that's at your own risk. 馃槃

@flexiondotorg @clefebvre @raveit65 @posophe @XRevan86 @willysr @obache
Note: if m-s-m package in your distros depends on/recommends/suggests libgksu2, it should be changed to gksu after this.

@willysr

This comment has been minimized.

Show comment
Hide comment
@willysr

willysr Mar 21, 2016

Member

is this for 1.12 or 1.14?
since i will be going with 1.12 for Slackware 14.2, i can have more time to test 1.14 whether i will go with a mixed build of GTK+2 and GTK+3 or go with all GTK+3 build only.

Member

willysr commented Mar 21, 2016

is this for 1.12 or 1.14?
since i will be going with 1.12 for Slackware 14.2, i can have more time to test 1.14 whether i will go with a mixed build of GTK+2 and GTK+3 or go with all GTK+3 build only.

@XRevan86

This comment has been minimized.

Show comment
Hide comment
@XRevan86

XRevan86 Mar 21, 2016

Maybe additionally xdg-su support :-)?

xdg-su -c 'foo --bar "1 2 3"'

XRevan86 commented Mar 21, 2016

Maybe additionally xdg-su support :-)?

xdg-su -c 'foo --bar "1 2 3"'
@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta Mar 21, 2016

Member

@willysr: it's for 1.14 (where m-s-m is GTK+3 only).

@XRevan86: pull requests are welcome as usual 馃槃

Member

monsta commented Mar 21, 2016

@willysr: it's for 1.14 (where m-s-m is GTK+3 only).

@XRevan86: pull requests are welcome as usual 馃槃

@willysr

This comment has been minimized.

Show comment
Hide comment
@willysr

willysr Mar 21, 2016

Member

that's good news (for me) :)

Member

willysr commented Mar 21, 2016

that's good news (for me) :)

@XRevan86

This comment has been minimized.

Show comment
Hide comment
@XRevan86

XRevan86 Mar 21, 2016

@monsta, it's no problem to implement but I guess I'll have to wait for this merge request to get merged.

XRevan86 commented Mar 21, 2016

@monsta, it's no problem to implement but I guess I'll have to wait for this merge request to get merged.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Mar 21, 2016

Member

Fedora does not use gksu or libgksu2.so.
We use beesu.
If i try to kill a process of another user i get simply a message that this isn't allowed 馃槃
So i can't test this.

Member

raveit65 commented Mar 21, 2016

Fedora does not use gksu or libgksu2.so.
We use beesu.
If i try to kill a process of another user i get simply a message that this isn't allowed 馃槃
So i can't test this.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Mar 21, 2016

Member

Using polkit /usr/bin/pkexec would be great.

Member

raveit65 commented Mar 21, 2016

Using polkit /usr/bin/pkexec would be great.

@monsta

This comment has been minimized.

Show comment
Hide comment
@monsta

monsta Mar 21, 2016

Member

I was going to add pkexec support from upstream but that looks like a bit more work than this. I'll add it later, but not sure if I'll do it in time for 1.14.

Member

monsta commented Mar 21, 2016

I was going to add pkexec support from upstream but that looks like a bit more work than this. I'll add it later, but not sure if I'll do it in time for 1.14.

@raveit65

This comment has been minimized.

Show comment
Hide comment
@raveit65

raveit65 Mar 21, 2016

Member

Np, it was never a problem in fedora, no reports about.
...for fedora it's more a new feature :)
Better we focus our work on existings PRs for 1.14

Member

raveit65 commented Mar 21, 2016

Np, it was never a problem in fedora, no reports about.
...for fedora it's more a new feature :)
Better we focus our work on existings PRs for 1.14

@monsta monsta merged commit 6e0ddb9 into master Mar 24, 2016

@monsta monsta deleted the dev-gksu branch Mar 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment