New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #30

Closed
carlwgeorge opened this Issue Apr 2, 2018 · 4 comments

Comments

Projects
None yet
6 participants
@carlwgeorge
Copy link

carlwgeorge commented Apr 2, 2018

Is this software compatible with Python 3? The README file says that Python 2.7 is required, but it isn't clear if that's a minimum requirement or if Python 2.7.x is needed.

If the software is compatible with Python 3, is it possible to install two versions at the same time, one linked against Python 2 and the other against Python 3? Perhaps by switching from:

  • /usr/lib64/caja/extensions-2.0/libcaja-python.so

to:

  • /usr/lib64/caja/extensions-2.0/libcaja-python2.so
  • /usr/lib64/caja/extensions-2.0/libcaja-python3.so

@vkareh vkareh added this to the 1.22 milestone Apr 5, 2018

@raveit65

This comment has been minimized.

Copy link
Member

raveit65 commented Jan 11, 2019

@monnerat

This comment has been minimized.

Copy link
Contributor

monnerat commented Jan 15, 2019

Well... it builds against python3, but there are problems at run-time: PyString_* functions have disappeared in python3 and I can see errors like (fedora 29 64-bit):
** (caja:4649): WARNING **: 19:59:44.100: /usr/lib64/caja/extensions-2.0/libcaja-python.so: undefined symbol: PyString_AsString
This is reported as a warning, but I guess it renders the library unusable.
I found it while investigating why rabbitvcs-caja is not showing in caja menus: maybe this is the reason, I have to check further.
It seems all python3 strings are unicode: I found that by googling: https://mail.python.org/pipermail/python-list/2009-March/527813.html

@encukou

This comment has been minimized.

Copy link

encukou commented Jan 16, 2019

Hello,
May I shamelessly suggest an open guide and compat header for handling the bytes/unicode split in C extensions?

I don't use caja (and I don't see automatic tests I could run), so I'm not the best person to do the porting, but I can help if you have any Python-related questions.

@monsta

This comment has been minimized.

Copy link
Member

monsta commented Feb 6, 2019

#34 and #35 are merged, so this project now has Python 3 compatibility (while still being compatible with Python 2).

@monsta monsta closed this Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment