Adding order create functionality #10

Merged
merged 3 commits into from Aug 21, 2014

Projects

None yet

2 participants

@rgerard
Contributor
rgerard commented Jul 11, 2014

Adding the ability to create orders in Coinbase.

@mateodelnorte
Owner

Hey @rgerard, thanks for the PR. I'm getting the following error when running 'make test':

coinbase.orders.post should generate a new order:
     TypeError: Object #<Object> has no method 'post'
      at Context.<anonymous> (/Users/matt/development/coinbase/test/index.js:178:21)
      at Test.Runnable.run (/Users/matt/development/coinbase/node_modules/mocha/lib/runnable.js:196:15)
      at Runner.runTest (/Users/matt/development/coinbase/node_modules/mocha/lib/runner.js:351:10)
      at /Users/matt/development/coinbase/node_modules/mocha/lib/runner.js:397:12
      at next (/Users/matt/development/coinbase/node_modules/mocha/lib/runner.js:277:14)
      at /Users/matt/development/coinbase/node_modules/mocha/lib/runner.js:286:7
      at next (/Users/matt/development/coinbase/node_modules/mocha/lib/runner.js:234:23)
      at Object._onImmediate (/Users/matt/development/coinbase/node_modules/mocha/lib/runner.js:254:5)
      at processImmediate [as _immediateCallback] (timers.js:336:15)
@mateodelnorte
Owner

...guessing you meant to simply write that as orders.create instead of orders.post.

Please be sure you run the tests and make sure they're all working before you issue a PR.

You'll probably want to move this test down under the describe.skip('WARNING', function() { (once you've ensured it works) at the bottom, too.

Thanks!

@rgerard
Contributor
rgerard commented Jul 16, 2014

Thanks @mateodelnorte. Sorry about the tests -- I thought I had run them, but clearly not. I addressed the comments, but when trying to run tests I did see "CoinbaseError: IP blocked" quite a bit. Let me know if you have any other thoughts for this PR.

@mateodelnorte
Owner

Do you have your IP enabled in your coinbase profile?

screenshot

On Jul 16, 2014 10:00 AM, "Ryan Gerard" notifications@github.com wrote:

Thanks @mateodelnorte https://github.com/mateodelnorte. Sorry about the
tests -- I thought I had run them, but clearly not. I addressed the
comments, but when trying to run tests I did see "CoinbaseError: IP
blocked" quite a bit. Let me know if you have any other thoughts for this
PR.


Reply to this email directly or view it on GitHub
#10 (comment).

@rgerard
Contributor
rgerard commented Jul 26, 2014

Sorry for the late reply! I left town for work, and I've finally found some time to get back to this.

Yes, that was the issue. Good catch. The tests are all passing, except for "coinbase.button should generate a new button". Coinbase is returning the error message, "You have not filled out your merchant profile. Please enter your information in the Profile section."

As far as I can tell, my merchant profile is definitely filled-out, so I'm not certain what they want me to fill. My new test is passing, however.

@rgerard
Contributor
rgerard commented Jul 26, 2014

Ha, nevermind, I found the merchant profile page and filled out the merchant info they wanted. All tests are passing now.

@rgerard
Contributor
rgerard commented Jul 30, 2014

Ping @mateodelnorte. Thoughts?

@mateodelnorte
Owner

I'll double check on this later today and merge if all looks good.

Cheers.

@rgerard
Contributor
rgerard commented Aug 16, 2014
@mateodelnorte mateodelnorte merged commit 46480ba into mateodelnorte:master Aug 21, 2014
@mateodelnorte
Owner

published to 0.1.3. Thanks and sorry for the wait.

@rgerard
Contributor
rgerard commented Aug 21, 2014

No problem! Thanks. Your library has been super useful.

@mateodelnorte
Owner

Glad to hear it!

On Thu, Aug 21, 2014 at 1:18 PM, Ryan Gerard notifications@github.com
wrote:

No problem! Thanks. Your library has been super useful.


Reply to this email directly or view it on GitHub
#10 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment