Skip to content

/ material-components-android

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] materialAlertDialogTheme is not public #769

Closed
ataulm opened this issue Nov 18, 2019 · 1 comment
Closed

[Dialog] materialAlertDialogTheme is not public #769

ataulm opened this issue Nov 18, 2019 · 1 comment
Labels
bug

Comments

@ataulm
Copy link
Contributor

@ataulm ataulm commented Nov 18, 2019

Description:

materialAlertDialogTheme is not explicitly marked as public, though similar theme attributes are in this file and the attribute is meant for public use.

This means that Lint will flag its usage in code:

image

Expected behavior:

I'd expect the attribute to be marked as public too, since it's used in a similar way to the other attributes, so that Lint doesn't flag it.

Material Library version:
1.1.0-beta02
@ataulm ataulm added the bug label Nov 18, 2019
@ataulm

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@ataulm ataulm commented Nov 19, 2019

Also if this is done, would it make sense to rename this to materialAlertDialogThemeOverlay to match materialThemeOverlay?
dsn5ft added a commit that referenced this issue Dec 18, 2019
@hunterstich @dsn5ft
Add materialAlertDialogTheme to public resources.
d142d69 
Resolves #769

PiperOrigin-RevId: 281547191
(cherry picked from commit 7601cfd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@ataulm
You can’t perform that action at this time.