Skip to content

Commit

Permalink
Do not set placeholderLabel.textColor to active color while editing w…
Browse files Browse the repository at this point in the history
…ith non-floating placeholder (#4850)

Closes #4844.

Previously, non-floating placeholder text color changed to `activeColor` while editing. An internal client sensed something incorrect about this, and Phil confirmed that it should stay set the value of `inlinePlaceholderColor`.

Before:
![simulator screen shot - iphone x - 2018-08-20 at 15 56 25](https://user-images.githubusercontent.com/8020010/44364338-b2ff7000-a494-11e8-95ec-a638ae7e9669.png)

After:
![simulator screen shot - iphone x - 2018-08-20 at 15 56 00](https://user-images.githubusercontent.com/8020010/44364339-b2ff7000-a494-11e8-82cf-7f580ae972a8.png)
  • Loading branch information
andrewoverton committed Aug 22, 2018
1 parent 6983358 commit 281392d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/TextFields/src/MDCTextInputControllerBase.m
Expand Up @@ -437,7 +437,7 @@ - (void)updatePlaceholder {
? self.errorColor
: nonErrorColor;
} else {
placeholderColor = self.textInput.isEditing ? self.activeColor : self.inlinePlaceholderColor;
placeholderColor = self.inlinePlaceholderColor;
}
if (!self.textInput.isEnabled) {
placeholderColor = self.disabledColor;
Expand Down

0 comments on commit 281392d

Please sign in to comment.