fix(chips): .d.ts file generated with syntax error #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way a comment was formatted in the chip foundation the .d.ts bundler ended up generating a file with a syntax error.
abhiomkar
reviewed
Feb 7, 2020
abhiomkar
approved these changes
Feb 7, 2020
abhiomkar
added a commit
that referenced
this pull request
Feb 7, 2020
abhiomkar
added a commit
that referenced
this pull request
Feb 7, 2020
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 7, 2020
For a while we were stuck on an older Canary version, because MDC was shipping an invalid .d.ts file to npm (see material-components/material-components-web#5577). These changes bump us to the latest one to hopefully resolve the master CI checks.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 7, 2020
For a while we were stuck on an older Canary version, because MDC was shipping an invalid .d.ts file to npm (see material-components/material-components-web#5577). These changes bump us to the latest one to hopefully resolve the master CI checks.
abhiomkar
added a commit
that referenced
this pull request
Feb 7, 2020
mmalerba
pushed a commit
to angular/components
that referenced
this pull request
Feb 7, 2020
For a while we were stuck on an older Canary version, because MDC was shipping an invalid .d.ts file to npm (see material-components/material-components-web#5577). These changes bump us to the latest one to hopefully resolve the master CI checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way a comment was formatted in the chip foundation the .d.ts bundler ended up generating a file with a syntax error.
For reference, here's what was being generated:
