feat(segmented-button): Added foundation business logic #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
requested changes
Jul 9, 2020
packages/mdc-segmented-button/segmented-button/test/foundation.test.ts
Outdated
Show resolved
Hide resolved
e111077
requested changes
Jul 10, 2020
gschrag
force-pushed
the
feat/segmented-button__foundation-business
branch
from
dfd04d7
to
dbe1339
Compare
gschrag
force-pushed
the
feat/segmented-button__foundation-business
branch
from
c778e4f
to
bcac084
Compare
|
This PR should be ready to merge. |
|
@e111077 Can you approve this PR? |
e111077
approved these changes
Jul 14, 2020
abhiomkar
reviewed
Jul 14, 2020
implement segment/foundation without accessibility
add aria-checked and aria-pressed manipulation for accessibility
implemented segmented-button foundation
improve name of isSingleSelect and use correct reference for @material/base
pull aria manipulation into helper function to clean and simplify code
add unit test outlines for segmented-button foundation
test segmented-button foundation business logic
wrap related tests in a describe block
child segment does not unselect self if singleSelect, so parent segmented-button does not need to check this
…nselect tested functionality is now in segment foundation
change logic from deny unselect to multiSelect to deny unselect to singleSelect
test new segment foundation business logic
better describe test cases, pull constants into separate files
fix test that fails due to unexpected unnecessary method calls
reorganize for more clear constants files and constant names
gschrag
force-pushed
the
feat/segmented-button__foundation-business
branch
from
4c853a3
to
2c6f042
Compare
abhiomkar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.