Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to MIT license #3376

Merged
merged 5 commits into from Aug 21, 2018
Merged

feat: update to MIT license #3376

merged 5 commits into from Aug 21, 2018

Conversation

lynnmercier
Copy link
Contributor

We're moving MDC Web to the MIT license.

At Google we prefer to license new projects under the Apache 2 license because we feel it gives the most rights to developers and creates a strong legal scaffold for projects to grow and thrive. However, what we've heard from users in the MDC Web community is that you prefer the MIT license. It's more widely used within JavaScript projects, it's shorter, and it’s better understood.

@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit a973acf vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ddd4511). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3376   +/-   ##
=========================================
  Coverage          ?   98.45%           
=========================================
  Files             ?      123           
  Lines             ?     5181           
  Branches          ?      639           
=========================================
  Hits              ?     5101           
  Misses            ?       80           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-menu-surface/index.js 99.02% <ø> (ø)
packages/mdc-menu/constants.js 100% <ø> (ø)
packages/mdc-animation/index.js 100% <ø> (ø)
packages/mdc-drawer/temporary/constants.js 100% <ø> (ø)
packages/mdc-chips/chip-set/constants.js 100% <ø> (ø)
packages/mdc-ripple/index.js 100% <ø> (ø)
packages/mdc-line-ripple/index.js 100% <ø> (ø)
packages/mdc-base/foundation.js 100% <ø> (ø)
packages/mdc-list/index.js 98.78% <ø> (ø)
packages/mdc-checkbox/index.js 100% <ø> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd4511...2222a39. Read the comment docs.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also update all instances of "license": "Apache-2.0" across package.jsons to "MIT".

Also, I guess we need to update the license blurb in every single source file... (I'd suggest going one file type at a time since the comment syntax is different for each.)

I imagine doing this will cause every package to get a version bump by lerna on the next release; I'm not sure if there's a way to avoid that (but I probably shouldn't be worrying about it anyway).

@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit d8c6fb1 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit 55555f5 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit cb35cb6 vs. master! 💯🎉

@kfranqueiro kfranqueiro changed the title chore: update to MIT license feat: update to MIT license Aug 21, 2018
@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit 79b8e54 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit 2222a39 vs. master! 💯🎉

1 similar comment
@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit 2222a39 vs. master! 💯🎉

@lynnmercier lynnmercier merged commit 2cf8487 into master Aug 21, 2018
@allan-chen allan-chen deleted the chore/license branch January 21, 2020 21:46
@HSH73
Copy link

HSH73 commented Jul 13, 2023

Hi, we're using MDC web and I was informed that a scan with ORT detected references to both MIT but also Apache in many components, despite the whole base was moved from Apache to MIT. For instance, in material base 15.0.0-canary.684e33d25.0 the scan detects

The MIT License
Copyright (c) 2014-2020 Google, Inc. Copyright Google LLC All Rights Reserved. Copyright 2016 Google Inc. Copyright 2019 Google Inc. Copyright 2018 Google Inc. Copyright 2021 Google Inc.
(...MIT license Text...), bu then as well
#Apache-2.0
Information found in:package/dist/mdc.base.js (https://www.npmjs.com/package/@material/base/v/15.0.0-canary.684e33d25.0?activeTab=code)
Licensed under the Apache License, Version 2.0 (the "License"); (,,,,)

We are struggeling to understand which license applies, or both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants