Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): Add cursor: pointer for interactive list items #4563

Merged
merged 6 commits into from Apr 3, 2019
Merged

fix(list): Add cursor: pointer for interactive list items #4563

merged 6 commits into from Apr 3, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Apr 2, 2019 •
edited

Fixes #4557

@joyzhong joyzhong changed the title fix(list): Add cursor: pointer for interactive list items. fix(list): Add cursor: pointer for interactive list items (#4557) Apr 2, 2019
@joyzhong joyzhong changed the title fix(list): Add cursor: pointer for interactive list items (#4557) fix(list): Add cursor: pointer for interactive list items (issue #4557) Apr 2, 2019
@joyzhong joyzhong changed the title fix(list): Add cursor: pointer for interactive list items (issue #4557) fix(list): Add cursor: pointer for interactive list items Apr 2, 2019
@mdc-web-bot
Copy link
Collaborator

All 633 screenshot tests passed for commit 38ded8c vs. master! 💯🎉

kfranqueiro
kfranqueiro suggested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably there should be some style(s) no longer necessary in mdc-menu now, right? Because that was applying cursor: pointer already.

packages/mdc-list/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-list/_mixins.scss Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from master on commit 2976f39:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from master on commit f921f7c:

Details

@mdc-web-bot
Copy link
Collaborator

All 633 screenshot tests passed for commit 45aba9c vs. master! 💯🎉

@joyzhong joyzhong merged commit d2f0ccb into master Apr 3, 2019
@joyzhong joyzhong deleted the mdc-list-hover branch April 3, 2019 01:47
abhiomkar pushed a commit that referenced this pull request Apr 9, 2019
@joyzhong @abhiomkar
fix(list): Add cursor: pointer for interactive list items (#4563)
0bba1fa 
Fixes #4557 

(cherry picked from commit d2f0ccb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfranqueiro kfranqueiro kfranqueiro approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joyzhong @mdc-web-bot @kfranqueiro @googlebot