Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid BEM naming for mixins #5408

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@jathak
Copy link
Contributor

jathak commented Jan 6, 2020

This replaces __ and -- in certain mixin names with a single dash to
allow migrating to the module system without breaking downstream users
that use these pseudoprivate mixins.

This replaces `__` and `--` in certain mixin names with a single dash to
allow migrating to the module system without breaking downstream users
that use these pseudoprivate mixins.
@googlebot googlebot added the cla: yes label Jan 6, 2020
@asyncLiz asyncLiz self-requested a review Jan 6, 2020
Copy link
Contributor

asyncLiz left a comment

LGTM!

Copy link
Contributor

abhiomkar left a comment

is there a CL for this?

Thanks!

@abhiomkar

This comment has been minimized.

Copy link
Contributor

abhiomkar commented Jan 9, 2020

Update: waiting for cl/288369347

@abhiomkar abhiomkar merged commit d4ea9a7 into material-components:master Jan 10, 2020
4 checks passed
4 checks passed
lint
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.