Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 馃敄 release v1.1.0-alpha #101

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

ChildishGiant
Copy link
Member

@ChildishGiant ChildishGiant commented Mar 31, 2021

This would be the first release of 1.1.0. At this point it is still in development and is not recommended for use in production. This includes a changelog and builds. For a GitHub release, that can be made once merged. For a preview you can look on my branch: https://github.com/ChildishGiant/materialize/releases/tag/v1.1.0-alpha

@ChildishGiant ChildishGiant changed the title chore: 馃敄 release v1.2.0-alpha chore: 馃敄 release v1.1.0-alpha Mar 31, 2021
@DanielRuf DanielRuf requested a review from a team April 1, 2021 16:17
@ChildishGiant
Copy link
Member Author

@materializecss/members Anyone had the chance to look at this? I need to update it with the last few commits but other than that it should be all fine

Copy link

@nicknickel nicknickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Smankusors
Copy link
Member

hmm wait, this v1.1.0-alpha doesn't include commits after 802bc19, is that correct?

@ChildishGiant
Copy link
Member Author

Updated the pull with all the latest commits 馃槃

Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielRuf do we need anything else on this PR?

@ChildishGiant
Copy link
Member Author

It's more about what needs to happen when this is merged, probably most important will be making the github release and running npm publish on the appropriate account.

@DanielRuf
Copy link

It's more about what needs to happen when this is merged, probably most important will be making the github release and running npm publish on the appropriate account.

Exactly. Any volunteer who wants to do the release then?
Afaik I have already given some permissions on npmjs.

@ChildishGiant
Copy link
Member Author

From a quick look it seems that @Smankusors and @nekonenene have permissions on the NPM package 馃憖

@Smankusors
Copy link
Member

Smankusors commented Apr 24, 2021

From a quick look it seems that @Smankusors and @nekonenene have permissions on the NPM package 馃憖

hmm wait wait, I'm currently still busy at the moment... 馃槄

btw is that as simple as login npm account and then execute npm publish?

@DanielRuf
Copy link

btw is that as simple as login npm account and then execute npm publish?

Exactly. Bump version number locally (1.1.0-alpha), create a new build, test, create tag and commit, push both to the GitHub repo and then hit npm publish (after npm login on the command line).

If something goes wrong we can unpublish versions with less than 100 installs or something like this and you can unpublish during a 24 hour period. We can test it with some v1.0.0-rc.17 build so you can test the steps (or some other pseudo release candidate number just for testing that only we know, should be unpublished afterwards).

@ChildishGiant
Copy link
Member Author

ChildishGiant commented Apr 24, 2021

You should be able to pull after merging this pr and publish from there, that way you have the changelog etc

A changelog can be found at CHANGELOG.md
@ChildishGiant ChildishGiant changed the title chore: 馃敄 release v1.1.0-alpha chore: 馃敄 release v1.1.0-alpha Apr 27, 2021
@Smankusors
Copy link
Member

Alright before I'm attempting to release, I want to ask about the versioning. Is this will be released as "1.1.0-alpha"? If in the future, the next version is still on alpha, should the next be :

  • 1.1.1-alpha
  • 1.1.0-alpha.1; or
  • something else?

If in the future still on alpha, should this version be named "1.1.0-alpha.1"?

@DanielRuf
Copy link

1.1.0-alpha.1; or

This. Then -rc, -rc.1 and final release milestone is v1.1.0.

@Smankusors Smankusors merged commit 57cd1d5 into materializecss:v1-dev Apr 28, 2021
@Smankusors
Copy link
Member

Alright I think the process finished 馃帀

  • npm run release
  • tagging a commit, push to GitHub
  • npm publish
  • release on GitHub

I think that's all...? Is there still something missing? 馃挱

@DanielRuf
Copy link

I think that's all...? Is there still something missing? thought_balloon

Spread the word =)

Awesomne, looks good so far:

grafik

Great work 馃憦

@ChildishGiant ChildishGiant deleted the v1.1.0-alpha branch September 18, 2021 23:30
@Smankusors Smankusors added the meta Issues with the project itself or our GitHub repository. label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues with the project itself or our GitHub repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants