-
-
Notifications
You must be signed in to change notification settings - Fork 107
chore: 🔖 release v1.1.0-alpha #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e88f54f to
0cc5076
Compare
|
@materializecss/members Anyone had the chance to look at this? I need to update it with the last few commits but other than that it should be all fine |
nicknickel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
hmm wait, this v1.1.0-alpha doesn't include commits after 802bc19, is that correct? |
0cc5076 to
5027c13
Compare
|
Updated the pull with all the latest commits 😄 |
Smankusors
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DanielRuf do we need anything else on this PR?
|
It's more about what needs to happen when this is merged, probably most important will be making the github release and running |
Exactly. Any volunteer who wants to do the release then? |
|
From a quick look it seems that @Smankusors and @nekonenene have permissions on the NPM package 👀 |
hmm wait wait, I'm currently still busy at the moment... 😅 btw is that as simple as login npm account and then execute |
Exactly. Bump version number locally ( If something goes wrong we can unpublish versions with less than 100 installs or something like this and you can unpublish during a 24 hour period. We can test it with some |
|
You should be able to pull after merging this pr and publish from there, that way you have the changelog etc |
A changelog can be found at CHANGELOG.md
5027c13 to
51322c6
Compare
|
Alright before I'm attempting to release, I want to ask about the versioning. Is this will be released as "1.1.0-alpha"? If in the future, the next version is still on alpha, should the next be :
If in the future still on alpha, should this version be named "1.1.0-alpha.1"? |
This. Then -rc, -rc.1 and final release milestone is v1.1.0. |
|
Alright I think the process finished 🎉
I think that's all...? Is there still something missing? 💭 |

This would be the first release of 1.1.0. At this point it is still in development and is not recommended for use in production. This includes a changelog and builds. For a GitHub release, that can be made once merged. For a preview you can look on my branch: https://github.com/ChildishGiant/materialize/releases/tag/v1.1.0-alpha