Merged
Conversation
|
I guess when we would replace the current build setup this could be easily prevented @Smankusors? |
Member
Author
eh, to be honest, I don't have any idea about alternative build setup 😅 |
LoganTann
reviewed
Oct 16, 2021
LoganTann
left a comment
There was a problem hiding this comment.
By reading the code, it looks even better than the original one.
However, I'm not experienced enough to tell if these changes are breaking something, nor proposing a better build system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
There's a breaking change when we updated the Waves 0.6 to Waves 0.7. The Waves 0.7 now have
module.exports, that inference with ourmodule.exports. This becomes a problem when we want to use materializecss withrequirefunction (usually in a node environment like testing a React app, not in the browser).I also merged the same arrays into one variable
jsFile.There should be no breaking change, but let me know if this ordering change somehow breaking something.
Code Example:
Output on materialize 1.0
Output on materialize 1.1-alpha
As you can see, the
Min the materialize 1.1-alpha is not from materialize, but from the Waves.Types of changes
Checklist: