Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #305

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Release 1.2.0 #305

merged 2 commits into from
Nov 24, 2022

Conversation

Smankusors
Copy link
Member

Proposed changes

Releasing 1.2.0, also

  1. seems like the original christinavoudouris goes missing, and I'm not sure the current one is actually the same person or different one?
  2. the global.js needs manual version replacing... I will tackle this later

Screenshots (if appropriate) or codepen:

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors Smankusors requested a review from a team November 19, 2022 14:31
@DanielRuf
Copy link

DanielRuf commented Nov 19, 2022

This (https://github.com/christinavoudouris) is still the same person (at a first glance). You can see on her LinkedIn profile.

I will check this in detail.

@mauromascarenhas
Copy link

Is it possible to await for #306 to be reviewed and merged? If so, we would have another component compatible with assistive technologies (sorry for not submitting it previously).

@mauromascarenhas
Copy link

mauromascarenhas commented Nov 23, 2022

Is it possible to await for #306 to be reviewed and merged? If so, we would have another component compatible with assistive technologies (sorry for not submitting it previously).

#306 has been merged. I can't see any other "impeditive" towards v1.2 release...

@wuda-io
Copy link
Member

wuda-io commented Nov 23, 2022

@Smankusors Do we need an additional manual commit for the changes of #306? So far it looks good to me.

@Smankusors
Copy link
Member Author

@Smankusors Do we need an additional manual commit for the changes of #306? So far it looks good to me.

@wuda-io oou wait, I will add it myself

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@wuda-io wuda-io merged commit 98389e4 into materializecss:main Nov 24, 2022
@mauromascarenhas
Copy link

It seems that "dist" files were not updated after #306 had been approved... Are they going to be updated later as well?

@Smankusors
Copy link
Member Author

It seems that "dist" files were not updated after #306 had been approved... Are they going to be updated later as well?

!!
goddamnit I forgot about this 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants