Skip to content

Fix disabled checked switch style#9

Merged
DanielRuf merged 1 commit into
materializecss:v1-devfrom
Smankusors:disabled-switch-style-patch
Aug 1, 2020
Merged

Fix disabled checked switch style#9
DanielRuf merged 1 commit into
materializecss:v1-devfrom
Smankusors:disabled-switch-style-patch

Conversation

@Smankusors
Copy link
Copy Markdown
Member

@Smankusors Smankusors commented Jul 26, 2020

Proposed changes

There's a style problem when a switch disabled but checked, the background color should be disabled color, not enabled color.

Reference design

Codepen:

Problem example

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note : This is from Dogfalo#6021

@Smankusors Smankusors marked this pull request as ready for review July 26, 2020 06:36
@Smankusors Smankusors mentioned this pull request Jul 26, 2020
Copy link
Copy Markdown

@Pierstoval Pierstoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Copy link
Copy Markdown

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielRuf DanielRuf merged commit 6c18460 into materializecss:v1-dev Aug 1, 2020
@DanielRuf
Copy link
Copy Markdown

Thanks for your contribution to materializecss.

I've invited you to the materializecss org as member and collaborator. You can view and accept the invitation at https://github.com/materializecss.

@Smankusors Smankusors deleted the disabled-switch-style-patch branch September 5, 2021 10:01
@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component: forms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants