Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled checked switch style #9

Merged

Conversation

Smankusors
Copy link
Member

@Smankusors Smankusors commented Jul 26, 2020

Proposed changes

There's a style problem when a switch disabled but checked, the background color should be disabled color, not enabled color.

Reference design

Codepen:

Problem example

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note : This is from Dogfalo#6021

@Smankusors Smankusors marked this pull request as ready for review Jul 26, 2020
@Smankusors Smankusors mentioned this pull request Jul 26, 2020
Copy link

@Pierstoval Pierstoval left a comment

Good catch 👍

Copy link

@DanielRuf DanielRuf left a comment

LGTM

@DanielRuf DanielRuf merged commit 6c18460 into materializecss:v1-dev Aug 1, 2020
1 check passed
@DanielRuf
Copy link

DanielRuf commented Aug 1, 2020

Thanks for your contribution to materializecss.

I've invited you to the materializecss org as member and collaborator. You can view and accept the invitation at https://github.com/materializecss.

@DanielRuf DanielRuf added this to In progress in development via automation Aug 15, 2020
@DanielRuf DanielRuf moved this from In progress to Done in development Aug 15, 2020
@Smankusors Smankusors deleted the disabled-switch-style-patch branch Sep 5, 2021
@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: forms
Projects
development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants