From fe1d2534a4b7c1d9e8d68622067c25b7c54a4524 Mon Sep 17 00:00:00 2001 From: JSX Date: Thu, 25 Mar 2021 13:04:47 -0700 Subject: [PATCH] Elec dev (#230) * added more fields to electrode doc * added elements field * linting * update * more useful fields * small fixes --- src/mp_api/electrodes/models.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mp_api/electrodes/models.py b/src/mp_api/electrodes/models.py index a79ec88c..3cd641fe 100644 --- a/src/mp_api/electrodes/models.py +++ b/src/mp_api/electrodes/models.py @@ -86,7 +86,7 @@ class InsertionElectrodeDoc(InsertionVoltageStep): battery_id: str = Field(None, description="The id for this battery document.") framework_formula: str = Field( - None, description="The id for this battery document." + None, description="The chemical formula without the working ion." ) host_structure: Structure = Field( @@ -94,17 +94,19 @@ class InsertionElectrodeDoc(InsertionVoltageStep): ) adj_pairs: List[InsertionVoltageStep] = Field( - None, description="Returns all the Voltage Steps", + None, + description="Returns all the Voltage Steps", ) working_ion: Element = Field( - None, description="The working ion as an Element object", + None, + description="The working ion as an Element object", ) - num_steps: float = Field( + num_steps: int = Field( None, description="The number of distinct voltage steps in from fully charge to " - "discharge based on the stable intermediate states", + "discharge based on the stable intermediate states", ) max_voltage_step: float = Field(