ruff select perflint flake8-slots

[janosh]

PEP 484 prohibits implicit Optional. To be a good Python citizen, this PR removes implicit optionals from all type hints.

[codecov]

Codecov Report

Merging #395 (4f7231d) into main (02e44c0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   64.96%   64.95%   -0.02%     
==========================================
  Files          74       74              
  Lines        7196     7193       -3     
  Branches      946      946              
==========================================
- Hits         4675     4672       -3     
  Misses       2221     2221              
  Partials      300      300              

Impacted Files	Coverage Δ
src/atomate2/common/schemas/cclib.py	73.82% <100.00%> (-0.18%)	⬇️
src/atomate2/cp2k/schemas/task.py	82.72% <100.00%> (-0.08%)	⬇️
src/atomate2/lobster/schemas.py	92.91% <100.00%> (-0.03%)	⬇️

[utf]

Personally, I'm not in favour of this. I really don't see the point of having to add the optional type when the default value is None. Mypy understands it fine. It just seems like extra boilerplate.

However, if there are other strong opinions I will hear them.

Edit: I didn't mean to close it.

[janosh]

@utf Don't feel strongly. I agree it's boilerplate even if more rigorous. I reverted the Optional changes and ignored the ruff rule RUF013 that applied them.

[utf]

Great, thank you.