Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lobsterpy version and schemas to match new version changes #637

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Dec 8, 2023

Changes

  • Update LobsterPy version
  • Fix schemas to match the recent release of LobsterPy

@naik-aakash
Copy link
Contributor Author

Hi @janosh , this PR is ready to be merged

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #637 (701c995) into main (04a5f93) will decrease coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   76.05%   75.89%   -0.16%     
==========================================
  Files          83       83              
  Lines        7033     7033              
  Branches     1044     1044              
==========================================
- Hits         5349     5338      -11     
- Misses       1363     1375      +12     
+ Partials      321      320       -1     
Files Coverage Δ
src/atomate2/lobster/schemas.py 91.15% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naik-aakash!

@janosh janosh added fix Bug fix PR version Package version-related issues labels Dec 8, 2023
@janosh janosh merged commit bd434a6 into materialsproject:main Dec 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR version Package version-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants