From 85850771bfbe5a3b7d60cb4a0d082b6c2acb1da3 Mon Sep 17 00:00:00 2001
From: Shyam D <shyamd@lbl.gov>
Date: Thu, 27 May 2021 14:15:34 -0700
Subject: [PATCH] remove deprecation from core since its in builders

---
 emmet-core/emmet/core/settings.py        | 4 ----
 emmet-core/emmet/core/vasp/validation.py | 9 ---------
 2 files changed, 13 deletions(-)

diff --git a/emmet-core/emmet/core/settings.py b/emmet-core/emmet/core/settings.py
index 4f096f0f84..68a1497394 100644
--- a/emmet-core/emmet/core/settings.py
+++ b/emmet-core/emmet/core/settings.py
@@ -79,10 +79,6 @@ class EmmetSettings(BaseSettings):
         description="Maximum upward gradient in the last SCF for any VASP calculation",
     )
 
-    VASP_DEPRECATED_TAGS: List[str] = Field(
-        [], description="List of tags to manually deprecate in task validation"
-    )
-
     VASP_USE_STATICS: bool = Field(
         True,
         description="Use static calculations for structure and energy along with structure optimizations",
diff --git a/emmet-core/emmet/core/vasp/validation.py b/emmet-core/emmet/core/vasp/validation.py
index ab3d46d795..9beb59d9bd 100644
--- a/emmet-core/emmet/core/vasp/validation.py
+++ b/emmet-core/emmet/core/vasp/validation.py
@@ -13,7 +13,6 @@
 
 class DeprecationMessage(DocEnum):
     MANUAL = "M", "manual deprecation"
-    DEPRECATED_TAGS = "M001", "Deprecated tag"
     KPTS = "C001", "Too few KPoints"
     KSPACING = "C002", "KSpacing not high enough"
     ENCUT = "C002", "ENCUT too low"
@@ -57,7 +56,6 @@ def from_task_doc(
         input_sets: Dict[str, PyObject] = SETTINGS.VASP_DEFAULT_INPUT_SETS,
         LDAU_fields: List[str] = SETTINGS.VASP_CHECKED_LDAU_FIELDS,
         max_allowed_scf_gradient: float = SETTINGS.VASP_MAX_SCF_GRADIENT,
-        deprecated_tags: List[str] = SETTINGS.VASP_DEPRECATED_TAGS,
     ) -> "ValidationDoc":
         """
         Determines if a calculation is valid based on expected input parameters from a pymatgen inputset
@@ -168,13 +166,6 @@ def from_task_doc(
         if max_gradient > max_allowed_scf_gradient:
             reasons.append(DeprecationMessage.MAX_SCF)
 
-        # Check for Manual deprecations
-        if deprecated_tags is not None:
-            bad_tags = list(set(task_doc.tags).intersection(deprecated_tags))
-            if len(bad_tags) > 0:
-                reasons.append(DeprecationMessage.DEPRECATED_TAGS)
-                data["bad_tags"] = bad_tags
-
         doc = ValidationDoc(
             task_id=task_doc.task_id,
             calc_type=calc_type,