Skip to content

fix GaussianOutput bug with multiple route lines #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

xjf729
Copy link
Contributor

@xjf729 xjf729 commented Apr 10, 2023

When route lines in gaussian output file like:

 ----------------------------------------------------------------------
 # B3LYP/6-311++G(2d,p) EmpiricalDispersion=GD3BJ SCRF=(SMD,READ) freq 
 opt=(loose,maxcyc=400)
 ----------------------------------------------------------------------

If we use GaussianOutput to parse route lines, route_parameters would be looked like as follows, in which, freq and opt are concatenate.

{'EmpiricalDispersion': 'GD3BJ',
  'SCRF': '(SMD,READ)',
  'freqopt': {'loose': None, 'maxcyc': '400'}}

Now, I fix the method to parse route lines, to give the right route_parameters:

{'EmpiricalDispersion': 'GD3BJ',
  'SCRF': '(SMD,READ)',
  'freq': None,
  'opt': {'loose': None, 'maxcyc': '400'}}

xjf729 and others added 4 commits April 10, 2023 16:30
when multiple completed lines in route parameters
delete only one space at the start of line
@janosh
Copy link
Member

janosh commented Apr 17, 2023

Could you zip the log file and load it as test_files/molecules/EC.log.gz using e.g. monty?

@janosh janosh added the awaiting user Needs more information from OP. label Apr 25, 2023
@xjf729
Copy link
Contributor Author

xjf729 commented Apr 27, 2023

I have zipped test_files/molecules/EC.log to test_files/molecules/EC.log.gz and set the zopen mode in GaussianOutput to "rt" to load .gz file.

@janosh janosh enabled auto-merge (squash) April 27, 2023 14:29
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @xjf729! 👍

@janosh janosh added io Input/output functionality fix Bug fix PRs and removed awaiting user Needs more information from OP. labels Apr 27, 2023
@janosh janosh merged commit 51280b9 into materialsproject:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PRs io Input/output functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants