Skip to content

fix GaussianOutput bug with multiple route lines - #2937

Merged
janosh merged 6 commits into
materialsproject:masterfrom
xjf729:fix-gaussianout
Apr 27, 2023
Merged

fix GaussianOutput bug with multiple route lines#2937
janosh merged 6 commits into
materialsproject:masterfrom
xjf729:fix-gaussianout

Conversation

@xjf729

@xjf729 xjf729 commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

When route lines in gaussian output file like:

 ----------------------------------------------------------------------
 # B3LYP/6-311++G(2d,p) EmpiricalDispersion=GD3BJ SCRF=(SMD,READ) freq 
 opt=(loose,maxcyc=400)
 ----------------------------------------------------------------------

If we use GaussianOutput to parse route lines, route_parameters would be looked like as follows, in which, freq and opt are concatenate.

{'EmpiricalDispersion': 'GD3BJ',
  'SCRF': '(SMD,READ)',
  'freqopt': {'loose': None, 'maxcyc': '400'}}

Now, I fix the method to parse route lines, to give the right route_parameters:

{'EmpiricalDispersion': 'GD3BJ',
  'SCRF': '(SMD,READ)',
  'freq': None,
  'opt': {'loose': None, 'maxcyc': '400'}}

xjf729 and others added 4 commits April 10, 2023 16:30
when multiple completed lines in route parameters
delete only one space at the start of line
@janosh

janosh commented Apr 17, 2023

Copy link
Copy Markdown
Member

Could you zip the log file and load it as test_files/molecules/EC.log.gz using e.g. monty?

@janosh janosh added the awaiting user Needs more information from OP. label Apr 25, 2023
@xjf729

xjf729 commented Apr 27, 2023

Copy link
Copy Markdown
Contributor Author

I have zipped test_files/molecules/EC.log to test_files/molecules/EC.log.gz and set the zopen mode in GaussianOutput to "rt" to load .gz file.

@janosh
janosh enabled auto-merge (squash) April 27, 2023 14:29

@janosh janosh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @xjf729! 👍

@janosh janosh added io Input/output functionality fix Bug fix PRs and removed awaiting user Needs more information from OP. labels Apr 27, 2023
@janosh
janosh merged commit 51280b9 into materialsproject:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix PRs io Input/output functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants