Minor modification for symmetrically distinct Miller index generation#2949
Merged
Conversation
…n asdcending order by the maximum of the absolute values of individual indices. This ensures that low-index surfaces are encountered and added to the list of unique Miller indices first.
Member
|
Nicely done and great comments! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2944
Fix:
conv_hkl_listis now sorted with respect to the maximum of the absolute values of the individual Miller indices it contains, before it is iterated over, ensuring that the unique Miller indices returned contain the lowest indices possible.