Skip to content

Fixed Wulff shape for new versions of matplotlib#2950

Merged
janosh merged 2 commits into
materialsproject:masterfrom
CifLord:wulff
Apr 22, 2023
Merged

Fixed Wulff shape for new versions of matplotlib#2950
janosh merged 2 commits into
materialsproject:masterfrom
CifLord:wulff

Conversation

@CifLord

@CifLord CifLord commented Apr 22, 2023

Copy link
Copy Markdown

Closes #2900.

Since matplotlib does not allow us to set auto_add_to_figure=True in Axes3D anymore passed ver. 3.6.0, I had to add the ax object to the Figure in order for it to properly display. Should now be backward/forward compatible for all versions of matplotlib.

@janosh janosh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CifLord Thanks for the fix! 🎉

@janosh janosh self-assigned this Apr 22, 2023
@janosh janosh added the fix Bug fix PRs label Apr 22, 2023
@janosh
janosh merged commit 1c81666 into materialsproject:master Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wulff plot not working

2 participants