Skip to content

Test figure returned by WulffShape.get_plot() contains single Axes3D#2953

Merged
janosh merged 1 commit intomasterfrom
test-wulff-get-plot-n-axes
Apr 25, 2023
Merged

Test figure returned by WulffShape.get_plot() contains single Axes3D#2953
janosh merged 1 commit intomasterfrom
test-wulff-get-plot-n-axes

Conversation

@janosh
Copy link
Copy Markdown
Member

@janosh janosh commented Apr 25, 2023

Follow-up to #2950. Improves the get_plot() test to make sure a regression causing an empty figure doesn't go unnoticed again.

…es3D instance

always run tests, regardless of os.environ.DISPLAY
@janosh janosh added fix Bug fix PRs data viz PRs and issues about pymatgen plotting functionality labels Apr 25, 2023
@janosh janosh enabled auto-merge (squash) April 25, 2023 00:47
@janosh janosh merged commit 872e410 into master Apr 25, 2023
@janosh janosh deleted the test-wulff-get-plot-n-axes branch April 25, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data viz PRs and issues about pymatgen plotting functionality fix Bug fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant