Breaking: Overhaul class PymatgenTest
#3014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but could break external code (though no one else should be using Pymatgen test routines)
use pytest.approx() instead which handles all iterable types incl. dict
…_allclose() involves renaming PymatgenTest.(assertArrayAlmostEqual -> assert_all_close) numpy docs recommend assert_allclose() over assert_almost_equal() and PymatgenTest.assertArrayAlmostEqual() is just a wrapper for assert_almost_equal() https://numpy.org/doc/stable/reference/generated/numpy.testing.assert_almost_equal.html
janosh
added
tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop unused
PymatgenTestmethods, rename existing ones from camel to snake case and replaceassert_almost_equalwithassert_allcloseas recommended by numpy docs.8ad0792 breaking: drop internally unused PymatgenTest.get_mp_structure()
8681792 breaking: drop internally unused PymatgenTest.assertDictsAlmostEqual()
62e9afc replace all PymatgenTest.assertArrayEqual with numpy.testing.assert_array_equal
9a1dfc1 remove PymatgenTest.assertArrayEqual() method
1462805 replace numpy.testing.assert_almost_equal() with numpy.testing.assert_allclose()
8a0e76e refactor import: from numpy.testing import assert_array_almost_equal
91013e1 breaking: snake_case assertStrContentEqual to assert_str_content_equal
729a5df breaking: snake_case assertMSONable to assert_msonable
Many of the commits here are breaking but since
PymatgenTestis only for internal use, it shouldn't matter.