Add Entry.elements property#3226
Merged
Merged
Conversation
previously (Structure|Entry).composition.elements
# normalization_factor, num_atoms should work from superclass > return self.__getattribute__(item) E AttributeError: 'MultiEntry' object has no attribute 'entry'
Signed-off-by: Janosh Riebesell <janosh.riebesell@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3226 +/- ##
=======================================
Coverage 74.57% 74.57%
=======================================
Files 230 230
Lines 69489 69493 +4
Branches 16168 16166 -2
=======================================
+ Hits 51820 51825 +5
Misses 14595 14595
+ Partials 3074 3073 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
36219e4 add property
elementstoEntryclass11ec642 use new
Structure.elementsandComposition.elementsproperties across pymatgenfc21570 add
test_elementsinTestPDEntryandTestTransformedPDEntry