fix: rotation after reflected by x axis

[mateuszJS]

Summary by CodeRabbit

• Refactor
  • Updated the logic for point transformations and rotation handling, resulting in changes to how UI elements respond during rotation interactions. This may affect the feel and orientation of rotated elements in the interface.

[coderabbitai]

Walkthrough

The transformation logic in the UI was updated to use a new reference angle for rotation calculations, shifting from the angle between the first and second points to the angle between the first and fourth points plus 90 degrees. Related angle calculations for pointer-based rotations and default angles were also adjusted to match this new reference frame.

Changes

File(s)	Change Summary
src/logic/transform_ui.zig	Modified transformation and rotation logic to use a new reference angle and updated angle formulas.

Poem

In the garden of angles, a twist anew,
The fourth point called, and the matrix flew.
Ninety degrees, a bunny's hop,
Rotations now spin with a fresher crop.
With paws on the compass, the UI feels right—
Transformations dancing in the moonlight!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb51f57 and 9ee3184.

📒 Files selected for processing (1)

• src/logic/transform_ui.zig (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Analyze (actions)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

src/logic/transform_ui.zig (3)

122-122: Ensure consistent usage of the new reference angle.

The change from asset_angle to asset_angle_y is consistent with the new reference frame, but verify that all related calculations have been updated accordingly.

The variable name change maintains consistency with the new vertical reference angle calculation.

---

43-46: Rotation reference angle change is isolated and correct

Our ripgrep search across the repository found no other uses of the old horizontal-based angle calculation. The new formula (points[0].angle_to(points[3]) + std.math.pi/2) only affects src/logic/transform_ui.zig and does not impact other modules.

• Reviewed locations:
– src/logic/transform_ui.zig:
• asset_angle_y definition
• Subsequent transform_matrix and inverse transform logic

No further updates are required. Consider adding unit tests for mirrored X-axis rotations to validate edge cases.

---

115-118: Rotation calculation is correct in inverted screen coordinates
The updated formula in src/logic/transform_ui.zig

const asset_new_angle = std.math.atan2(
    asset_center.y - raw_y,
    asset_center.x - raw_x,
) - std.math.pi / 2.0;

is mathematically equivalent (mod 2π) to the previous

atan2(raw_y - asset_center.y, raw_x - asset_center.x) + π/2

and correctly accounts for the downward‐pointing Y axis in screen space. Underlying rotation behavior is already validated by the existing Matrix3x3.rotation tests in src/logic/matrix.zig. No further changes required.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

🎉 This PR is included in version 0.1.0-next.5 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀