Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HB.structure should not declare the class projection as canonical #27

Closed
CohenCyril opened this issue Jan 7, 2020 · 3 comments · Fixed by #192
Closed

HB.structure should not declare the class projection as canonical #27

CohenCyril opened this issue Jan 7, 2020 · 3 comments · Fixed by #192
Assignees
@CohenCyril
Milestone
1.1.0

Comments

@CohenCyril
Copy link
Member

We should either let this projection be anonymous and redeclare it by pattern matching later, or make Coq not register it when 8.11 is out.

hierarchy-builder/hb.elpi

Line 711 in e118e77

field ff "class" (app [global ClassName, s]) _\

@gares
Copy link
Member

gares commented Jan 7, 2020

I think I should add support for attributes, IIRC we can say #[canonical(false)] in 8.11.

@gares
Copy link
Member

gares commented Feb 27, 2020

it is for 8.11 indeed, I hope to release coq-elpi 1.3 for 8.11 soon, then I'll move coq-elpi master on Coq 8.11 and will add this attribute to record fields.

@gares gares changed the title class projection should not be canonical HB.structure should not declare the class projection as canonical Feb 27, 2020
@gares
Copy link
Member

gares commented May 7, 2020

API is now available (requires Coq 8.11 I guess) https://github.com/LPCIC/coq-elpi/blob/25f51646ae8fd201188db1d6deb61d5c00175030/coq-builtin.elpi#L317-L321

@gares gares self-assigned this May 7, 2020
@CohenCyril CohenCyril added this to the 1.0 milestone Jul 17, 2020
@gares gares modified the milestones: 1.0.0, 1.1.0 Dec 16, 2020
@gares gares assigned CohenCyril and unassigned gares Mar 25, 2021
@CohenCyril CohenCyril mentioned this issue Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CohenCyril CohenCyril

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

making the class non canonical math-comp/hierarchy-builder
2 participants
@CohenCyril @gares