Skip to content

Conversation

@gares
Copy link
Member

@gares gares commented May 18, 2020

to be merged when coq-elpi 1.4 is out

Fix #52

@gares
Copy link
Member Author

gares commented May 19, 2020

I've update CI, but it should be re-run when rocq-prover/opam#1257 gets merged

@gares
Copy link
Member Author

gares commented May 19, 2020

Also, I've blindly patched nix... @CohenCyril you'd better check what I did

@CohenCyril
Copy link
Member

CohenCyril commented May 19, 2020

Also, I've blindly patched nix... @CohenCyril you'd better check what I did

Nix CI is green and the patch looks good to me, so good job 😉

@gares
Copy link
Member Author

gares commented May 20, 2020

I think we should consider rebasing once more parameters on this, and then merge parameters in master. BTW the opam package for coq-elpi 1.4 is released, so opam-based CI should be fixable

@CohenCyril
Copy link
Member

shall we merge and release now?

@gares
Copy link
Member Author

gares commented May 20, 2020

I'd say we should merge. Releasing can wait I think.

@CohenCyril CohenCyril merged commit 43dbc5c into master May 20, 2020
@CohenCyril
Copy link
Member

Releasing can wait I think.

I need it for NixOS/nixpkgs#87711

@CohenCyril CohenCyril deleted the coq-elpi-1.4 branch May 20, 2020 20:39
@gares
Copy link
Member Author

gares commented May 20, 2020

ok, then tag a minor 0.9.1 or something. But the changelog needs some care I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HB.mixin should not rename the type variable

3 participants