New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding allrel predicate #558
Conversation
97b2a2e
to
89501d0
Compare
It looks ok to me, but I'm not in love with the |
Also, is it useful to have |
It may happen that a relation is decidable even on some non discrete types (e.g. a pair of an ordered type with a no discrete type), and I would like to preserve the full generality of the theorem on such occurences. |
I went back and forth a lot in the naming: the working name was the ugly |
Actually I would have gone for |
Well, the predicate states that "all pairs of |
In any event, |
+1 To me the thing is messy because |
While the string "allpairs" appears in a considerable number of of lemmas, the definition |
I'm all in favor of |
I saw that, allpairs maps a function overs all the pairs, which could be named, to me, map_allpairs. Anyway, I'm OK with the renaming proposed by @chdoc |
89501d0
to
cfa038f
Compare
I fixed the names, made the proof shorter and more readable and introduced the |
cfa038f
to
893615e
Compare
I have a new name suggestion: how about
|
I approve, in particular because it avoids the |
893615e
to
6a21bbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (apart from the grammar error in the changelog 😏 )
5ba0d6f
to
bf7d1d3
Compare
bf7d1d3
to
b81aa92
Compare
@gares all good? |
Motivation for this change
This predicate is useful in stating that a sequence of matrices all commute.
This is a part of #207.
Things done/to do
CHANGELOG_UNRELEASED.md
Automatic note to reviewers
Read this Checklist and make sure there is a milestone.