Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #44

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@kud
Copy link
Contributor

commented Oct 3, 2019

No description provided.

@math2001

This comment has been minimized.

Copy link
Owner

commented Oct 23, 2019

[just me thinking outloud 😄 ]

I was thinking about creating a message for package control (under messages/) to notify users, as they would need to update their own setting file, to use the typo-free name. But, those Package Control update messages are quite annoying, and I never really read them.

On the other hand, what I find unintersting are "new features" and "bug fixes", since they don't require anything from the user. In this case, it does. A user having used that setting would have to rename it.

Thoughts? This is clearly a minute issue, which probably affects exactly 0 users, but still, it's interesting to think about what would the most appropriate general behavior. And in this case, I think it is to notify users because it requires user intervention. So, I'll probably set up a message for v1.4.9.

@math2001 math2001 merged commit d795ca6 into math2001:master Oct 23, 2019
@math2001

This comment has been minimized.

Copy link
Owner

commented Oct 23, 2019

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.