New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to proper subroute when clicking a crumb #145

Open
okputadora opened this Issue Jan 30, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@okputadora
Copy link
Member

okputadora commented Jan 30, 2019

These are "crumbs"
crumb

They let the user know where they are. Right now, if you click MyVMT it redirects to /myVMT/courses. The desired behavior is for it to redirect to /myVMT/rooms when you're on a room page, /myVMT/activities when you're on an activity page and /myVMT/courses when you're on a course page.

The place to change these redirects would be in the render methods of Containers/Room, Containers/Activity (Containers/Course already has the desired behavior.

If you're feeling ambitious you could also add some tests to /cypress/integration/navigation.js to confirm the changes you've made work.

@myles-painter

This comment has been minimized.

Copy link

myles-painter commented Feb 1, 2019

Hi! I'd like to give this a try

@jyothisankarreddy

This comment has been minimized.

Copy link

jyothisankarreddy commented Feb 2, 2019

I can try this

@okputadora

This comment has been minimized.

Copy link
Member Author

okputadora commented Feb 4, 2019

@myles-painter go for it! Let us know if you need any help getting the project set up. I've just added a .env.example to the repo which you will need to get it up and running.

@jyothisankarreddy we're going to give out tasks on a first-come first-served basis so let's let myles take this one. We will have more issues for first-timers soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment